Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

www-misc/profile-sync-daemon: add masked 6.28 and 9999 version #2262

Closed
wants to merge 1 commit into from
Closed

www-misc/profile-sync-daemon: add masked 6.28 and 9999 version #2262

wants to merge 1 commit into from

Conversation

soredake
Copy link
Contributor

@soredake soredake commented Sep 6, 2016 •
edited

Added new masked systemd-only version.
Eapi bump on older version.

mgorny
mgorny reviewed Sep 6, 2016
View reviewed changes
profiles/package.mask
@@ -30,6 +30,11 @@

#--- END OF EXAMPLES ---

# Since 6.0, Profile Sync Daemon developers removed all non-systemd
support, so it won't be compatible with any other init that's not systemd.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got missing # here.

@mgorny
Copy link
Member

mgorny commented Sep 6, 2016

FYI, the malformed p.mask killed pkgcheck, so please fix it and push over to get QA check results.

@soredake
Copy link
Contributor Author

soredake commented Sep 6, 2016

Oops, fixed.

@doughdemon
Copy link
Contributor

Is the eapi bump of the older (stable!) version intentionally included in this PR?

@soredake
Copy link
Contributor Author

soredake commented Sep 7, 2016 •
edited

Yes, i should update the description?

@gktrk
Copy link
Member

gktrk commented Sep 20, 2016

@gentoo/proxy-maint

@gktrk gktrk added version bump assigned PR successfully assigned to the package maintainer(s). labels Sep 20, 2016
@soredake soredake changed the title www-misc/profile-sync-daemon: add masked 6.25 version www-misc/profile-sync-daemon: add masked 6.2{5,8} and 9999 version Oct 15, 2016
@soredake soredake changed the title www-misc/profile-sync-daemon: add masked 6.2{5,8} and 9999 version www-misc/profile-sync-daemon: add masked 6.28 and 9999 version Oct 31, 2016
@gktrk gktrk self-assigned this Nov 7, 2016
@gktrk
Copy link
Member

gktrk commented Nov 8, 2016

I don't think masking is the right approach here. It's better to check REPLACING_VERSIONS and ewarn about openrc support being dropped. We can't keep the versions <6 in the tree forever, so masking only delays the inevitable.

@gktrk
Copy link
Member

gktrk commented Nov 9, 2016

Also, seems like /etc/psd.conf is no longer supported. We should have an einfo to that effect in pkg_postinst along with openrc support being dropped.

@soredake
Copy link
Contributor Author

soredake commented Nov 9, 2016

Commit updated.

gktrk
gktrk suggested changes Nov 9, 2016
View reviewed changes
Copy link
Member

@gktrk gktrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add www-=misc/profile-sync-daemon to profiles/features/selinux/package.mask ? Looks like systemd is masked on selinux profiles.

profiles/package.mask
@@ -208,7 +208,7 @@ media-gfx/skencil
net-wireless/chillispot

# Pacho Ramos <pacho@gentoo.org> (08 Oct 2016)
# Fails to build (#515294), nothing needs it, relies on obsolete capi4kutils.
# Fails to build (#515294), nothing needs it, relies on obsolete capi4kutils.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erroneous whitespace here.

www-misc/profile-sync-daemon/profile-sync-daemon-5.45.1.ebuild

inherit eutils vcs-snapshot
inherit eutils
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any reason to inherit eutils. Am I missing something?

www-misc/profile-sync-daemon/profile-sync-daemon-6.28.ebuild
pkg_postinst() {
local replacing
for replacing in ${REPLACING_VERSIONS}; do
if [[ "$(get_major_version ${replacing})" == "5" ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_major_version is provided by the versionator eclass, so it should be inherited properly.

@soredake
Copy link
Contributor Author

soredake commented Nov 9, 2016

Rebased and updated.

gktrk
gktrk reviewed Nov 10, 2016
View reviewed changes
www-misc/profile-sync-daemon/profile-sync-daemon-6.28.ebuild

SRC_URI="https://github.com/graysky2/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz"
KEYWORDS="~amd64 ~x86"
RESTRICT="mirror"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this package mirror restricted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restrict removed.

@gentoo-repo-qa-bot
Copy link
Collaborator

😞 The QA check for this pull request has found the following issues:

Issues inherited from Gentoo (may be modified by PR):
https://qa-reports.gentoo.org/output/gentoo-ci/4a8c4dc/output.html#net-im/qutim

@gktrk
Copy link
Member

gktrk commented Nov 10, 2016

Merged in bab1492...9e31234. Thanks!

@gktrk gktrk closed this Nov 10, 2016
@soredake soredake deleted the psync_bump branch November 10, 2016 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gktrk gktrk gktrk requested changes

Assignees

@gktrk gktrk

Labels
assigned PR successfully assigned to the package maintainer(s).
Projects
None yet
Milestone
No milestone
5 participants
@soredake @mgorny @doughdemon @gktrk @gentoo-repo-qa-bot