Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-misc/rsync: Passing --disable-asm to myeconfargs array [ADVA] #22667

Closed
wants to merge 1 commit into from

Conversation

wikjas
Copy link
Contributor

@wikjas wikjas commented Oct 22, 2021

The optimization works properly only for x86_64 arch, so there is no need to use asm for other archs.
Comparing the output of present compiler, use of asm has no impact on performance.

Here are the results of cross-compilation with unchagned ebuild (amd64 - native):
powerpc64 x86_64-vm armv7 aarch64 i686
fail ok fail fail fail

native
ok

From the logs of failed compilation:

./lib/md5-asm-x86_64.S:698: Error: unrecognized opcode: pop' ./lib/md5-asm-x86_64.S:699: Error: unrecognized opcode: ret'
./lib/md5-asm-x86_64.S:65: Error: unsupported relocation against %rdi
./lib/md5-asm-x86_64.S:683: Error: unsupported relocation against $64
./lib/md5-asm-x86_64.S:684: Error: unsupported relocation against %rdi
If you can't fix the issue, re-run ./configure with --disable-asm.

And here the results with changed ebuild (amd64 - native):
powerpc64 x86_64-vm armv7 aarch64 i686
ok ok ok ok ok

native
ok

As it was suggested in the discussion: #22354 (comment) #22354 (comment) of my previous pull request i added --disable-asm in the myeconfargs array,
i also applied it conditionally for the x86_64.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @wikjas
Areas affected: ebuilds
Packages affected: net-misc/rsync

net-misc/rsync: @gentoo/base-system

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Oct 22, 2021
@thesamesam
Copy link
Member

You're welcome to just force push in the branch for the other PR (#22354). Are you sure you've addressed our comments over there...?

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-10-22 08:55 UTC
Newest commit scanned: 0ed6e31
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/48339f170e/output.html

@wikjas
Copy link
Contributor Author

wikjas commented Oct 22, 2021

You're welcome to just force push in the branch for the other PR (#22354). Are you sure you've addressed our comments over there...?

I edited the description with the links to your comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
4 participants