net-misc/rsync: Passing --disable-asm to myeconfargs array [ADVA] #22667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimization works properly only for x86_64 arch, so there is no need to use asm for other archs.
Comparing the output of present compiler, use of asm has no impact on performance.
Here are the results of cross-compilation with unchagned ebuild (amd64 - native):
powerpc64 x86_64-vm armv7 aarch64 i686
fail ok fail fail fail
native
ok
From the logs of failed compilation:
./lib/md5-asm-x86_64.S:698: Error: unrecognized opcode:
pop' ./lib/md5-asm-x86_64.S:699: Error: unrecognized opcode:
ret'./lib/md5-asm-x86_64.S:65: Error: unsupported relocation against %rdi
./lib/md5-asm-x86_64.S:683: Error: unsupported relocation against $64
./lib/md5-asm-x86_64.S:684: Error: unsupported relocation against %rdi
If you can't fix the issue, re-run ./configure with --disable-asm.
And here the results with changed ebuild (amd64 - native):
powerpc64 x86_64-vm armv7 aarch64 i686
ok ok ok ok ok
native
ok
As it was suggested in the discussion: #22354 (comment) #22354 (comment) of my previous pull request i added --disable-asm in the myeconfargs array,
i also applied it conditionally for the x86_64.