Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-vcs/git fixes #22700

Closed
wants to merge 2 commits into from
Closed

dev-vcs/git fixes #22700

wants to merge 2 commits into from

Conversation

floppym
Copy link
Contributor

@floppym floppym commented Oct 25, 2021 •
edited

  • Avoid using ${D} before src_install (PMS compliance)
  • Install symlinks instead of hardlinks to fix FEATURES="splitdebug"

Bug: https://bugs.gentoo.org/820107

@floppym
dev-vcs/git: avoid using ${D} before src_install
1cb4c7a 
Signed-off-by: Mike Gilbert <floppym@gentoo.org>
@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Oct 25, 2021
@floppym floppym requested a review from robbat2 October 25, 2021 00:48
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-10-25 01:00 UTC
Newest commit scanned: f561d18
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/632074f95e/output.html

@floppym
dev-vcs/git: install symlinks instead of hard links
130953b 
Symlinks work better with Portage's splitdebug feature.

With hard links, .gnu_debuglink gets set randomly to one of the link names.
This can cause gdb to fail to find the debug file.

With symlinks, .gnu_debuglink always gets set to "git.debug", and gdb is always
set to "git.debug", and gdb is able to find the debug file consistently.

Bug: https://bugs.gentoo.org/820107
Signed-off-by: Mike Gilbert <floppym@gentoo.org>
@floppym floppym removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Oct 25, 2021
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @floppym
Areas affected: ebuilds
Packages affected: dev-vcs/git

dev-vcs/git: @robbat2, polynomial-c

Linked bugs

Bugs linked: 820107

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Oct 25, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-10-25 01:25 UTC
Newest commit scanned: 130953b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4feed3da15/output.html

@floppym floppym closed this Oct 25, 2021
@floppym
Copy link
Contributor Author

floppym commented Oct 25, 2021

Closed in favor of gentoo/portage#763.

@floppym floppym deleted the git-links branch October 31, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbat2 robbat2 Awaiting requested review from robbat2

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
3 participants
@floppym @gentoo-repo-qa-bot @gentoo-bot