sci-mathematics/nusmv: version bump to 2.6.0 + EAPI bump. #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sed -i -e "s:share/nusmv/doc:share/doc/${PF}:" "${S}"/doc/{tutorial,user-man,prog-man}/CMakeLists.txt || die | ||
|
|
||
| # Correction for proper parallel compilation | ||
| # sed -i -e 's/COMMAND ${MAKE}/COMMAND $(MAKE)/' "${WORKDIR}/${MY_P}/"{zchaff,MiniSat}/CMakeLists.txt || die |
There was a problem hiding this comment.
Could not fix the parallel building issue yet
g-braeunlich
force-pushed
the
sci-mathematics/nusmv
branch
2 times, most recently
from
6c9f49a
to
9b7e0f1
Compare
| HOMEPAGE="http://nusmv.fbk.eu/" | ||
| SRC_URI="http://nusmv.fbk.eu/distrib/${NUSMV_A} | ||
| minisat? ( https://github.com/niklasso/minisat/archive/${MINISAT_A} ) | ||
| zchaff? ( http://www.princeton.edu/~chaff/zchaff/${ZCHAFF_A} )" |
There was a problem hiding this comment.
please unbundle these and turn them into proper packages
monsieurp
added
version bump
assigned
monsieurp
changed the title
g-braeunlich
force-pushed
the
sci-mathematics/nusmv
branch
2 times, most recently
from
a804a64
to
4953997
Compare
|
@g-braeunlich could you unbundle minisat now that its in the tree with all the latest patches? |
|
@g-braeunlich could you rebase the merge commits, the unbundling into the |
g-braeunlich
force-pushed
the
sci-mathematics/nusmv
branch
2 times, most recently
from
424fd77
to
ba5a4f5
Compare
SoapGentoo
reviewed
Sep 19, 2016
| sed -i -e 's/-mcpu=[^\s]*//' "${WORKDIR}/${MY_P}/cudd-2.4.1.1"/Makefile || die | ||
| # Prevent automatic build of minisat - we are using the ebuild from portage | ||
| sed -i -e 's/ add_subdirectory(${MINISAT_SOURCE_DIR} ${MINISAT_BUILD_DIR})//' \ | ||
| -e 's/MINISAT_LIB/MiniSat/' CMakeLists.txt |
g-braeunlich
force-pushed
the
sci-mathematics/nusmv
branch
from
ba5a4f5
to
9180750
Compare
SoapGentoo
reviewed
Sep 21, 2016
| # Prevent automatic build of minisat - we are using the ebuild from portage | ||
| sed -i -e 's/ add_subdirectory(${MINISAT_SOURCE_DIR} ${MINISAT_BUILD_DIR})//' \ | ||
| -e 's/MINISAT_LIB/MiniSat/' CMakeLists.txt | ||
| sed -i -e 's/DEPENDS MINISAT_BUILD//' code/nusmv/core/sat/solvers/CMakeLists.txt |
| dev-texlive/texlive-latexextra | ||
| app-doc/doxygen | ||
| ) | ||
| minisat? ( >=sci-mathematics/minisat-2.2.0_p20130925 ) |
There was a problem hiding this comment.
have you checked that minisat is a pure build-time only dependency? I kinda doubt this, as I recall minisat installing shared objects, which means that nusmv likely links against it.
|
|
||
| S="${WORKDIR}/${MY_P}/NuSMV" | ||
|
|
||
| DOCS=( AUTHORS NEWS README{,_MiniSat,_PLATFORMS,_zChaff}.txt ) |
There was a problem hiding this comment.
have you tried whether you really need to specify these?
g-braeunlich
force-pushed
the
sci-mathematics/nusmv
branch
from
9180750
to
f0c1d1b
Compare
Package-Manager: portage-2.2.28
Package-Manager: portage-2.2.28
gentoo-bot
pushed a commit
that referenced
this pull request
Sep 24, 2016
Package-Manager: portage-2.2.28 Closes: #2271 Signed-off-by: David Seifert <soap@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revbump to 2.6.0. Also porting to EAPI 6. Also porting to EAPI 6