-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-python/passlib: Advertise Argon2 support #22750
dev-python/passlib: Advertise Argon2 support #22750
Conversation
Dropped support for Python 3.7. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
b88b4de
to
882dc3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the work and investigation!
I haven't tested or confirmed those changes, but here are very small changes meanwhile.
# Distributed under the terms of the GNU General Public License v2 | ||
|
||
EAPI=8 | ||
PYTHON_COMPAT=( python3_{8..10} pypy3 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add new empty line after EAPI=
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, done.
@@ -21,8 +21,9 @@ MY_P="Radicale-${PV}" | |||
RDEPEND=" | |||
acct-user/radicale | |||
acct-group/radicale | |||
dev-python/bcrypt[${PYTHON_USEDEP}] | |||
dev-python/defusedxml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it wasn't you fault, but let's fix errors we find :)
dev-python/defusedxml | |
dev-python/defusedxml[${PYTHON_USEDEP}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that's always a good idea!
I didn't really look much into the radicale ebuilds. I intended to give them some care in a separate change since they are currently umaintained.
Also, for every package whose ebuild you change the |
Pull request CI reportReport generated at: 2021-10-29 09:25 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
882dc3f
to
d825a98
Compare
Removed USE dependency on dev-python/passlib[bcrypt]. Bumped revision. Bug: https://bugs.gentoo.org/820668 Package-Manager: Portage-3.0.28, Repoman-3.0.3 Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
…ython/defusedxml Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
d825a98
to
cc5c814
Compare
Pull request CI reportReport generated at: 2021-10-29 11:15 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull Request assignmentSubmitter: @seifertm dev-python/passlib: @prometheanfire, @gentoo/openstack, @gentoo/python Linked bugsBugs linked: 820668 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2021-10-29 11:30 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Based on those lines, and multiple extra docs in this repo, I think
I have also scanned those others dependencies, and haven't found other misses. Very good job! |
…bcrypt Bug: https://bugs.gentoo.org/820668 Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
…encies with optfeature messages Bug: https://bugs.gentoo.org/820668 Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Closes: https://bugs.gentoo.org/820668 Package-Manager: Portage-3.0.28, Repoman-3.0.3 Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
cc5c814
to
c52e44a
Compare
Thanks for the thorough review! I added bcrypt to the test dependencies of the |
Pull request CI reportReport generated at: 2021-10-29 13:45 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Adds a new revision: passlib-1.7.4-r1
PYTHON_COMPAT
IUSE
entries for optional runtime dependencies withoptfeature
messages (see below)Before removing the USE flags, I checked the reverse deps of passlib to make sure none of them would break when removing
bcrypt
scrypt
, andtotp
:app-admin/ansible-base
: Uses passlib (pbkdf2) for tests so it should not be affected by the changedev-python/autobahn
: Usespasslib.utils.saslprep
so it should not be affected by the changedev-python/flask-security
: Implicitly depends on passlib[totp] for multi factor authentication. However, the only package in Portage that uses flask-security isdev-db/pgadmin4
. Pgadmin4, in turn, does not seem to use the multi-factor auth feature from flask-security.dev-python/pypiserver
: Usespasslib.apache
so it should not be affected by the changedev-libs/Ice
: Usespasslib.hash
with pbkdf2_sha512 so it should not be affected by the changedev-db/pgadmin4
: Depends on passlib, but doesn't seem to use it directly.net-mail/mailman
: Usespasslib.utils
to generate passwords so it should not be affected by the changenet-proxy/mitmproxy
: Usespasslib.apache
so it should not be affected by the changesys-libs/libxcrypt
: Allegedly uses passlib's pure Python implementations as a test dependency. Tests still succeed whendev-python/bcrypt
anddev-python/scrypt
are removed from the systemwww-apps/radicale/radicale
: Has an explicit dependency onpasslib[bcrypt]
. This has been broken up into a dependency on passlib and another one on bcrypt