Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update glibc to make libcrypt.so.1 an orphaned file #22833

Closed
wants to merge 1 commit into from
Closed

Update glibc to make libcrypt.so.1 an orphaned file #22833

wants to merge 1 commit into from

Conversation

floppym
Copy link
Contributor

@floppym floppym commented Nov 5, 2021

No description provided.

@floppym floppym added do not merge Please DO NOT MERGE this PR. It will not be assigned but it will be scanned by CI. work in progress The PR is not yet ready to be merged. labels Nov 5, 2021
@ZeroChaos-
Copy link
Contributor

This should help avoid failures with FEATURES="-preserve-libs protect-owned"
If this (or similar) isn't accepted, then a pkg_setup die should be added as protect-owned will prevent libxcrypt from installing after the -preserve-libs hack in the glibc ebuild

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-05 17:50 UTC
Newest commit scanned: 438e67d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4797600913/output.html

@floppym
Copy link
Contributor Author

floppym commented Nov 5, 2021

There's a risk involved here: /lib/libcrypt.so.1 will deleted for the short period between pkg_preinst and pkg_postinst.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-05 18:05 UTC
Newest commit scanned: 3972182
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5c5b1c568b/output.html

@floppym
sys-libs/glibc: preserve libcrypt.so.1 as an orphan
2732a26 
This should help users who have FEATURES="-preserve-libs protect-owned".

Signed-off-by: Mike Gilbert <floppym@gentoo.org>
@floppym floppym removed work in progress The PR is not yet ready to be merged. do not merge Please DO NOT MERGE this PR. It will not be assigned but it will be scanned by CI. labels Nov 5, 2021
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @floppym
Areas affected: ebuilds
Packages affected: sys-libs/glibc

sys-libs/glibc: @gentoo/toolchain

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Nov 5, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-05 18:20 UTC
Newest commit scanned: 2732a26
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8c0184ae7f/output.html

@gentoo-bot gentoo-bot closed this in f10efb4 Nov 6, 2021
@ZeroChaos-
Copy link
Contributor

Thanks!

@floppym floppym deleted the preserve-orphan branch November 6, 2021 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
4 participants
@floppym @ZeroChaos- @gentoo-repo-qa-bot @gentoo-bot