sci-libs/superlu_mt: fix int64 not taking effect #23063
Conversation
Pull Request assignmentSubmitter: @alexfanqi sci-libs/superlu_mt: @gentoo/sci Linked bugsBugs linked: 817680 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2021-11-24 04:00 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
upstream uses unconventional variables names. int64 adds _LONG_INT to PREDEFS. PREDEFS seems to be a synonym of CPPFLAGS and used sparingly to be appended to CFLAGS. It should be passed to $(CC) explicitly for int64 to take effect. EXAMLE/Makefile should include ../make.in, which is the same in upstream. Closes: https://bugs.gentoo.org/817680 Signed-off-by: Alex Fan <alex.fan.q@gmail.com>
Pull request CI reportReport generated at: 2021-11-28 12:10 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
tested on riscv64 and amd64
USE=int64 doesn't actually take effect. int_t is still typedefed as int instead of long long on machines with 32 bit int like RISC-V lp64 ABI. PREDEFS should be appended to CFLAGS. This is also the case in upstream.
and there is no make.inc under EXAMPLE/, EXAMPLE/Makefile should read ../make.inc