kernel-2.eclass: Respect portage CC variable #23091
Conversation
Pull Request assignmentSubmitter: @10ne1 @gentoo/github Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. New packagesThis Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
the
need assignment
Pull request CI reportReport generated at: 2021-11-26 15:30 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
I asked for comments from other developers and they had concerns with this change and potential unintended impacts. Can this be posted to the mailing list (gentoo-dev) to get more input, please? |
|
@mpagano Ok I'll also send to the mailing list, thanks! |
|
@mpagano I sent the patch to the ML 2 weeks ago and nobody responded. Should I CC/send to someone explicitely or should I wait a bit more considering the holiday season is approaching? |
|
Some devs had real concerns, I would ask in #gentoo-hardened on irc. Or maybe ping gyakovlev directly for comment. |
10ne1
force-pushed
the
dev/aratiu/kernel-eclass-fix-CC-variable
branch
from
e2f05e1
to
bf59aee
Compare
Pull request CI reportReport generated at: 2021-12-15 15:35 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Starting with kernel>=v5.7 the build system can override the tools vars by setting LLVM=1 [1], but older kernels still use the default GNU tools, so to be able to use a full LLVM/Clang build, CC & co should be set to their respective portage values. [1] a0d1c951ef08 kbuild: support LLVM=1 to switch the default tools to Clang/LLVM Co-authored-by: Manoj Gupta <manojgupta@chromium.org> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com> --- Changes in v3: - Add rest of vars used by kernel builds (suggested by James) - Minor commit msg rewording Changes in v2: - Set AR variable which is also required for linux-headers - Reword msg for clarity
10ne1
force-pushed
the
dev/aratiu/kernel-eclass-fix-CC-variable
branch
from
bf59aee
to
604c9e0
Compare
Pull request CI reportReport generated at: 2022-01-03 18:00 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
kernel-2.eclass: Respect portage CC & AR variables
Starting with kernel>=v5.7 the build system can override the
tools vars by setting LLVM=1 [1], but older kernels still use
the default GNU tools, so to be able to use a full LLVM/Clang
build, CC should be set together with AR to the portage set
values.
Doing this avoids situations like building the kernel with
clang (using the set HOSTCC) but using gcc/gnu-ar for headers.
[1] a0d1c951ef08 kbuild: support LLVM=1 to switch the default tools to Clang/LLVM
Co-authored-by: Manoj Gupta manojgupta@chromium.org
Signed-off-by: Adrian Ratiu adrian.ratiu@collabora.com