app-emulation/crun: add 1.3 #23105
Closed
app-emulation/crun: add 1.3 #23105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: https://bugs.gentoo.org/827821 Package-Manager: Portage-3.0.28, Repoman-3.0.3 Signed-off-by: Alexey Zapparov <alexey@zapparov.com>
Pull Request assignmentSubmitter: @ixti app-emulation/crun: Linked bugsBugs linked: 827821 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2021-11-29 04:25 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
juippis
reviewed
Nov 30, 2021
There was a problem hiding this comment.
It looks like +criu is perhaps missing some dep?
In file included from src/libcrun/criu.c:26:
/usr/include/criu/criu.h:25:10: fatal error: rpc.pb-c.h: No such file or directory
25 | #include "rpc.pb-c.h"
| ^~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:1522: src/libcrun/libcrun_la-criu.lo] Error 1
make: *** Waiting for unfinished jobs....
[ERROR] >>> Not all runs were successful.
atom: =app-emulation/crun-1.3, USE flags: 'bpf -caps criu -seccomp -static-libs'
atom: =app-emulation/crun-1.3, USE flags: 'bpf -caps criu seccomp -static-libs'
atom: =app-emulation/crun-1.3, USE flags: '-bpf -caps criu -seccomp static-libs'
Co-authored-by: juippis <juippis@gmail.com>
|
@juippis thanks for checking that. I do have |
ixti
added a commit
to ixti/ixti-overlay
that referenced
this pull request
Nov 30, 2021
Upstream: gentoo/gentoo#23105 Package-Manager: Portage-3.0.28, Repoman-3.0.3 Signed-off-by: Alexey Zapparov <alexey@zapparov.com>
ixti
added a commit
to ixti/ixti-overlay
that referenced
this pull request
Nov 30, 2021
Pull request CI reportReport generated at: 2021-11-30 14:55 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Yeah the patch is purely cosmic :P can you show me what these print for you: |
juippis
reviewed
Dec 1, 2021
| systemd? ( sys-apps/systemd:= ) | ||
| " | ||
| RDEPEND="${DEPEND}" | ||
| BDEPEND="${PYTHON_DEPS}" |
There was a problem hiding this comment.
Note: Also needs to BDEPEND on virtual/pkgconfig
There was a problem hiding this comment.
For criu only, right? so it should be something like:
Suggested change
| BDEPEND="${PYTHON_DEPS}" | |
| BDEPEND=" | |
| ${PYTHON_DEPS} | |
| criu? ( virtual/pkgconfig ) | |
| " |
There was a problem hiding this comment.
No, crun itself needs it. Not related to an USE flag here.
|
@juippis sure, full output of equery |
|
One more thing: Can you post your build.log (as an attachment here for example) with I'm kind of guessing at this point that crun somehow bundles it, but I tried to find it from the source tarball directly without help. I can't downgrade criu to 3.15 because I guess what it looks like a glibc/gcc mismatch. |
|
Sure! https://gist.github.com/ixti/a31df74ed739ea17d8e030858cc8fd66 |
juippis
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
I can't crack it. Just one more question please: What version of glibc and gcc are you running?
Let's push this for others to figure out.
See also https://bugs.gentoo.org/822006
LOL. Works for me! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://bugs.gentoo.org/827821
Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: Alexey Zapparov alexey@zapparov.com