app-editors/vim: remove warning due to missing defaults.vim #23115
Conversation
Pull Request assignmentSubmitter: @dongsupark app-editors/vim: @gentoo/vim Linked bugsBugs linked: 820356 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
|
Won't this collide with vim-core? |
Pull request CI reportReport generated at: 2021-11-29 16:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
@thesamesam |
I could have vim-core installed independently though, I think (even if this seems unlikely)? It seems like it would then collide. |
vim >= 8.2.3428 prints out a warning on missing file, when it is built with USE="minimal" and `app-editors/vim-core` is not installed. ``` $ vim E1187: Failed to source defaults.vim Press ENTER or type command to continue ``` To remove warning, explicitly install /usr/share/vim/vim82/defaults.vim. Closes: https://bugs.gentoo.org/820356 Signed-off-by: Dongsu Park <dpark@linux.microsoft.com>
dongsupark
force-pushed
the
dongsu/vim-minimal-defaults
branch
from
de72a36
to
c4f82f2
Compare
|
Thanks, you are right. |
Pull request CI reportReport generated at: 2021-11-30 15:20 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
This looks good now (we need || die on external commands like 'sed', see https://devmanual.gentoo.org/ebuild-writing/error-handling/) but could you verify gvim is okay now? i.e. Does gvim use the file that vim-core used to install? Or does it not affect gvim? |
Delete skip_defaults_vim config options from /etc/vimrc, to avoid conflicts with vim[minimal]. Delete /usr/share/vim/vim82/defaults.vim, to avoid conflicts with vim[minimal]. Signed-off-by: Dongsu Park <dpark@linux.microsoft.com>
dongsupark
force-pushed
the
dongsu/vim-minimal-defaults
branch
from
c4f82f2
to
bae0189
Compare
|
Thanks, updated the PR to add Checked also gvim. That is not affected by vim-core at all. |
Pull request CI reportReport generated at: 2021-12-01 17:05 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Thanks for being thorough here! Really appreciate the PR. |
|
Oh, note for future: we should've possibly revbumped here (it changes the installed files/runtime behaviour of these) but it seems like a trivial issue and we're going to end up bumping for the never-ending CVEs shortly enough I suspect, so not worth it. |
vim >= 8.2.3428 prints out a warning on missing file, when it is built with USE="minimal" and `app-editors/vim-core` is not installed. ``` $ vim E1187: Failed to source defaults.vim Press ENTER or type command to continue ``` To remove warning, explicitly install /usr/share/vim/vim82/defaults.vim. This issue was fixed via gentoo/gentoo#23115. That fix was already included in #255, but only for main. That's why we need to fix it also in maintenance branches. Gentoo ref: fc72192754c8a1ff9014fd739a2d07056b25ed1e
Delete skip_defaults_vim config options from /etc/vimrc, to avoid conflicts with vim[minimal]. Delete /usr/share/vim/vim82/defaults.vim, to avoid conflicts with vim[minimal]. To remove warning, explicitly install /usr/share/vim/vim82/defaults.vim. This issue was fixed via gentoo/gentoo#23115. That fix was already included in #255, but only for main. That's why we need to fix it also in maintenance branches. Gentoo ref: 74eaf6b7cbab24337eae5c07d42871aeb21a330e
vim >= 8.2.3428 prints out a warning on missing file, when it is built with USE="minimal" and `app-editors/vim-core` is not installed. ``` $ vim E1187: Failed to source defaults.vim Press ENTER or type command to continue ``` To remove warning, explicitly install /usr/share/vim/vim82/defaults.vim. This issue was fixed via gentoo/gentoo#23115. That fix was already included in #255, but only for main. That's why we need to fix it also in maintenance branches. Gentoo ref: fc72192754c8a1ff9014fd739a2d07056b25ed1e
Delete skip_defaults_vim config options from /etc/vimrc, to avoid conflicts with vim[minimal]. Delete /usr/share/vim/vim82/defaults.vim, to avoid conflicts with vim[minimal]. To remove warning, explicitly install /usr/share/vim/vim82/defaults.vim. This issue was fixed via gentoo/gentoo#23115. That fix was already included in #255, but only for main. That's why we need to fix it also in maintenance branches. Gentoo ref: 74eaf6b7cbab24337eae5c07d42871aeb21a330e
vim >= 8.2.3428 prints out a warning on missing file, when it is built with USE="minimal" and `app-editors/vim-core` is not installed. ``` $ vim E1187: Failed to source defaults.vim Press ENTER or type command to continue ``` To remove warning, explicitly install /usr/share/vim/vim82/defaults.vim. This issue was fixed via gentoo/gentoo#23115. That fix was already included in flatcar-archive/portage-stable#255, but only for main. That's why we need to fix it also in maintenance branches. Gentoo ref: fc72192754c8a1ff9014fd739a2d07056b25ed1e
Delete skip_defaults_vim config options from /etc/vimrc, to avoid conflicts with vim[minimal]. Delete /usr/share/vim/vim82/defaults.vim, to avoid conflicts with vim[minimal]. To remove warning, explicitly install /usr/share/vim/vim82/defaults.vim. This issue was fixed via gentoo/gentoo#23115. That fix was already included in flatcar-archive/portage-stable#255, but only for main. That's why we need to fix it also in maintenance branches. Gentoo ref: 74eaf6b7cbab24337eae5c07d42871aeb21a330e
vim >= 8.2.3428 prints out a warning on missing file, when it is built with USE="minimal" and
app-editors/vim-coreis not installed.To remove the warning, explicitly install /usr/share/vim/vim82/defaults.vim.
Closes: https://bugs.gentoo.org/820356
Signed-off-by: Dongsu Park dpark@linux.microsoft.com