x11-base/xorg-server: restore setuid for non-systemd/logind meson build #23160
Conversation
The meson build does not support the autotools build option install-setuid and when not using systemd or logind the suid_wrapper is not equivalent as it does not resolve tty or input device permissions unless /etc/X11/Xwrapper.config is created with; allowed_users = anybody needs_root_rights = yes In which case you can skip the wrapper as this would be the default preference when using startx or xinit without systemd or logind from the console or init scripts. So revert to previous autotools build behaviour. Signed-off-by: Alan Swanson <reiver@improbability.net>
Pull Request assignmentSubmitter: @alanswanson x11-base/xorg-server: @gentoo/x11 Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2021-12-03 13:20 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Just to inform https://bugs.gentoo.org/828462 was opened which I believe is about the same issue. |
|
The way the ebuild has been modified isn't optimal, you've completely cut out the wrapper and instead just went with the old suid way, which is fine (I prefer that myself) but others might just want the wrapper option. You need to take that into account, and the easiest way is to have another flag, "suid" changes suid of binary, "wrap" allows wrapper including setting suid properly on the wrap program. |
|
I am fine with the way this pull request make changes. The old behavior was pure suid and not wrapper unless logind interface was present. I am interested to hear other comments but unless any significant one will pop up, I will merge it. |
The meson build does not support the autotools build option install-setuid and when not using systemd or logind the suid_wrapper is not equivalent as it does not resolve tty or input device permissions unless /etc/X11/Xwrapper.config is created with;
allowed_users = anybody
needs_root_rights = yes
(Note needs_root_rights=auto only checks video card permissions and nothing else.)
In which case you can skip the wrapper as this would be the default preference when using startx or xinit without systemd or logind from the console or init scripts. So revert to previous autotools build behaviour.
Signed-off-by: Alan Swanson reiver@improbability.net