Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-util/radare2: verbump to 5.5.4 #23184

Closed
wants to merge 1 commit into from
Closed

dev-util/radare2: verbump to 5.5.4 #23184

wants to merge 1 commit into from

Conversation

stkw0
Copy link
Contributor

@stkw0 stkw0 commented Dec 4, 2021

Closes: https://bugs.gentoo.org/815046
Bug: https://bugs.gentoo.org/790284
Bug: https://bugs.gentoo.org/807061

Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: David Roman davidroman96@gmail.com

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @stkw0
Areas affected: ebuilds
Packages affected: dev-util/radare2

dev-util/radare2: @stkw0, @gentoo/proxy-maint

Linked bugs

Bugs linked: 790284, 807061, 815046

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. security PR that needs to be merged promptly as it addresses security issues labels Dec 4, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-12-05 00:22 UTC
Newest commit scanned: 66c3d7f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ee3e13d5fa/output.html

juippis
juippis reviewed Dec 17, 2021
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

* QA Notice: Symbolic link /usr/lib64/radare2/last points to /usr/lib64/radare2/5.5.0 which does not exist.

Huh?

# file /usr/lib64/radare2/last
/usr/lib64/radare2/last: broken symbolic link to 5.5.0

 * VDB: detected possibly incorrect RDEPEND (dev-util/radare2-5.5.0)
 * dev-libs/libzip | dev-libs/libzip:=

@stkw0 stkw0 changed the title dev-util/radare2: verbump to 5.5.0 dev-util/radare2: verbump to 5.5.4 Dec 22, 2021
@stkw0
Copy link
Contributor Author

stkw0 commented Dec 22, 2021

tbh I don't know why radare2 creates /usr/lib64/radare2 folder when it doesn't put anything there, but at least with the current ebuild I don't see that symlink issue.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-12-22 15:02 UTC
Newest commit scanned: d68024b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/59f6a963ae/output.html

@ajakk
Copy link
Member

ajakk commented Dec 24, 2021 •
edited

Doesn't seem like the test phase is working properly?

>>> Test phase: dev-util/radare2-5.5.4
make -j24   test
make: 'test' is up to date.
>>> Completed testing dev-util/radare2-5.5.4

I'm not sure how much radare2 and rizin have diverged at this point, but some prefix mangling inside tests might be necessary, you might be able to adapt some patches from dev-util/rizin.

Note that I've also disabled tests in Rizin due to ambiguous licensing on the binaries they distribute, so would probably be necessary to do that here too.

@stkw0
Copy link
Contributor Author

stkw0 commented Dec 28, 2021

Note that I've also disabled tests in Rizin due to ambiguous licensing on the binaries they distribute, so would probably be necessary to do that here too.

If we recompile those binaries then it won't be a problem right? Although I guess we will have to search all different licenses of all the sources and add those to LICENSE

@ajakk
Copy link
Member

ajakk commented Dec 28, 2021

Note that I've also disabled tests in Rizin due to ambiguous licensing on the binaries they distribute, so would probably be necessary to do that here too.

If we recompile those binaries then it won't be a problem right? Although I guess we will have to search all different licenses of all the sources and add those to LICENSE

Correct, and there's so many that I've not done this yet

@stkw0
Copy link
Contributor Author

stkw0 commented Jan 3, 2022

thanks. For now I will just do as you and disable tests, when I do the work of searching for the difference licenses and so I will enable it again.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-01-03 17:17 UTC
Newest commit scanned: a25d9dd
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/41792607dc/output.html

ajakk
ajakk reviewed Jan 4, 2022
View reviewed changes
dev-util/radare2/radare2-5.5.4.ebuild Outdated
# Copyright 1999-2022 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2

EAPI=7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EAPI=8?

dev-util/radare2/radare2-5.5.4.ebuild
IUSE="ssl"

# Need to audit licenses of the binaries used for testing
RESTRICT="test"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to get tests working locally? This situation is obviously not ideal, but ensuring tests work for at least yourself would be great.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, kind of, it works if I first emerge emerge radare2 and then I execute the tests. I don't know if it's possible to do an src_install before src_test is executed so all needed libs and binaries and in the correct paths, changing the path to include all stuff seems very ugly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's possible to do an src_install before src_test is executed so all needed libs and binaries and in the correct paths, changing the path to include all stuff seems very ugly.

Yes, you can use the "${BUILD_DIR}" most likely for that. It's somewhat commonly used, the python eclasses even has built-in helpers for that.

@ajakk
Copy link
Member

ajakk commented Jan 4, 2022

Other than these minor nits, lgtm

@stkw0
dev-util/radare2: verbump to 5.5.4
7ad9451 
Closes: https://bugs.gentoo.org/815046
Bug: https://bugs.gentoo.org/790284
Bug: https://bugs.gentoo.org/807061

Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: David Roman <davidroman96@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-01-05 02:32 UTC
Newest commit scanned: 5948656
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2da70a584e/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-01-05 02:47 UTC
Newest commit scanned: 7ad9451
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e012868f44/output.html

@gentoo-bot gentoo-bot closed this in 6857fe4 Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis left review comments

@ajakk ajakk ajakk left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. security PR that needs to be merged promptly as it addresses security issues self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
5 participants
@stkw0 @gentoo-bot @gentoo-repo-qa-bot @ajakk @juippis