Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eclass/ruby-fakegem.eclass: updated extensions dir according to formula from rubygems #23205

Closed
wants to merge 1 commit into from

Conversation

andrew-aladev
Copy link
Contributor

Hello. There is an old bug 423589 about failing rdoc installation on i686 systems for ruby <= 2.6. I've reproduced it and found inconsistency between ruby fakegem and native ruby gem functionality.

Please review original extensions formula from ruby source/lib/rubygems/basic_specification.
Today ruby fakegem uses RbConfig::CONFIG['arch'] instead of Gem::Platform.local.to_s. Gem::Platform.local.to_s won't always equal to RbConfig::CONFIG['arch']. For example on i686 system:

Gem::Platform.local.to_s = 'x86-linux'
RbConfig::CONFIG['arch'] = 'i686-linux'

We can see that ruby-fakegem uses wrong i686-linux folder for extensions.

I've investigated ruby releases from v2_1 to 3_0: extensions directory formula is the same. So I am proposing to use it for ruby-fakegem eclass.

Thank you.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @andrew-aladev
Areas affected: eclasses
Packages affected: (none)

@gentoo/github

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. no signoff One or more commits do not indicate GCO sign-off. labels Dec 6, 2021
…la from rubygems

Signed-off-by: Andrew Aladjev <aladjev.andrew@gmail.com>

Bug: https://bugs.gentoo.org/423589

Closes: https://bugs.gentoo.org/423589
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-12-07 18:26 UTC
Newest commit scanned: 354fd21
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/475a84adfd/output.html

@graaff
Copy link
Member

graaff commented Feb 6, 2022

Thanks for digging in to this and checking how rubygems derives the extensions dir name. I have merged this commit.

I think it's unlikely that that old bug was caused by this, but certainly it was causing issues for rdoc installation right now, e.g. https://bugs.gentoo.org/832268.

@graaff graaff closed this Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need assignment It was impossible to assign the PR correctly. Please assign it manually. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
4 participants