Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media-libs/netpbm: fix compilation with hardened clang #23207

Closed
wants to merge 1 commit into from
Closed

media-libs/netpbm: fix compilation with hardened clang #23207

wants to merge 1 commit into from

Conversation

ceamac
Copy link
Contributor

@ceamac ceamac commented Dec 7, 2021

Add -fPIC to CFLAGS_FOR_BUILD if CFLAGS also has it.

CC_FOR_BUILD is only used for some internal tools and for testing. I think leaking CFLAGS over CFLAGS_FOR_BUILD may break cross compilation.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @ceamac
Areas affected: ebuilds
Packages affected: media-libs/netpbm

media-libs/netpbm: @ceamac, @gentoo/proxy-maint

Linked bugs

Bugs linked: 828127

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 7, 2021
thesamesam
thesamesam reviewed Dec 7, 2021
View reviewed changes
media-libs/netpbm/netpbm-10.86.27.ebuild
@@ -3,7 +3,7 @@

EAPI=8

inherit multilib toolchain-funcs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I asked this before: are we actually using multilib.eclass?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do, pkgcheck scan reports if we don't. I just checked on another package:

UnusedInherits: version 1.3.5: unused eclass: multilib

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it and got

IndirectInherits: version 10.86.27: multilib: indirect inherit usage: 'get_libname', line 58

Great tool :)

@ceamac
media-libs/netpbm: fix compilation with hardened clang
75aa6b6 
Closes: https://bugs.gentoo.org/828127
Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: Viorel Munteanu <ceamac.paragon@gmail.com>
@ceamac ceamac force-pushed the media-libs/netpbm/bug-828127 branch from c9cc180 to 75aa6b6 Compare December 7, 2021 08:55
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-12-07 19:55 UTC
Newest commit scanned: 75aa6b6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/935442a3c0/output.html

@gentoo-bot gentoo-bot closed this in 7c21d5b Dec 8, 2021
@ceamac ceamac deleted the media-libs/netpbm/bug-828127 branch August 13, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam thesamesam left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@ceamac @gentoo-bot @gentoo-repo-qa-bot @thesamesam