app-admin/integrit: update to EAPI 8 #23286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request assignmentSubmitter: @scardracs app-admin/integrit: @gentoo/proxy-maint (maintainer needed) Linked bugsBugs linked: 450752 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
maintainer-needed
|
Why does this need a revbump? Also, use a descirptive commit summary. |
Pull request CI reportReport generated at: 2021-12-13 08:20 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ghost
changed the title
|
@thesamesam better? |
Pull request CI reportReport generated at: 2021-12-13 08:35 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2021-12-13 08:50 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Tags like "Closes" should be at the end with signed-off-by. I still think the summary (not the commit message itself, although that's better) is too vague. It should be "update to EAPI 8" or similar. But I still wouldn't bother revbumping for this. |
ghost
changed the title
I thought moving to EAPI 8 requires a revbump. If you think it's not required I'll do it when I'm at home (I've changed the one on GH to be sure to remember how to change it) |
Pull request CI reportReport generated at: 2021-12-14 20:37 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
juippis
reviewed
Dec 20, 2021
There was a problem hiding this comment.
Generally we do revbump on EAPI updates, yeah,
https://devmanual.gentoo.org/general-concepts/ebuild-revisions/index.html
it's also a lot easier for the reviewer. I don't really see a reason to do 7->8 bump in any case.
but because this isn't stable, nor does it have reverse dependencies, this is fine.
However...
>>> Failed to emerge app-admin/integrit-4.2_rc1, Log file:
>>> '/var/tmp/portage/vbslogs/build/app-admin/integrit-4.2_rc1:20211220-133128.log'
>>> Jobs: 18 of 19 complete, 1 failed Load avg: 0.73, 0.23, 0.08
* Package: app-admin/integrit-4.2_rc1
* Repository: gentoo
* Maintainer: marco@scardovi.com proxy-maint@gentoo.org
* USE: abi_x86_64 amd64 elibc_glibc kernel_linux userland_GNU
* FEATURES: network-sandbox preserve-libs sandbox userpriv usersandbox
>>> Unpacking source...
>>> Unpacking integrit-4.2_rc1.tar.gz to /var/tmp/portage/app-admin/integrit-4.2_rc1/work
>>> Source unpacked in /var/tmp/portage/app-admin/integrit-4.2_rc1/work
>>> Preparing source in /var/tmp/portage/app-admin/integrit-4.2_rc1/work/integrit-4.2-rc1 ...
* Applying integrit-4.1-fix-build-system.patch ...
[ ok ]
* Running eautoreconf in '/var/tmp/portage/app-admin/integrit-4.2_rc1/work/integrit-4.2-rc1/hashtbl' ...
* Running 'aclocal' ...
[ ok ]
* Running 'autoconf --force' ...
[ ok ]
* Running 'autoheader' ...
[ ok ]
* Running eautoreconf in '/var/tmp/portage/app-admin/integrit-4.2_rc1/work/integrit-4.2-rc1' ...
* Running 'aclocal' ...
[ ok ]
* Running 'autoconf --force' ...
[ ok ]
* Running 'autoheader' ...
[ ok ]
* Running elibtoolize in: integrit-4.2-rc1/
* Running elibtoolize in: integrit-4.2-rc1/hashtbl/
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/app-admin/integrit-4.2_rc1/work/integrit-4.2-rc1 ...
* econf: updating integrit-4.2-rc1/config.guess with /usr/share/gnuconfig/config.guess
* econf: updating integrit-4.2-rc1/config.sub with /usr/share/gnuconfig/config.sub
* econf: updating integrit-4.2-rc1/hashtbl/config.guess with /usr/share/gnuconfig/config.guess
* econf: updating integrit-4.2-rc1/hashtbl/config.sub with /usr/share/gnuconfig/config.sub
./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --datarootdir=/usr/share --docdir=/usr/share/doc/integrit-4.2_rc1 --htmldir=/usr/share/doc/integrit-4.2_rc1/html --libdir=/usr/lib64
checking for x86_64-pc-linux-gnu-gcc... x86_64-pc-linux-gnu-gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C... yes
checking whether x86_64-pc-linux-gnu-gcc accepts -g... yes
checking for x86_64-pc-linux-gnu-gcc option to enable C11 features... none needed
checking whether make sets $(MAKE)... yes
checking for gawk... gawk
checking for x86_64-pc-linux-gnu-ar... x86_64-pc-linux-gnu-ar
checking the archiver (x86_64-pc-linux-gnu-ar) interface... ar
checking for x86_64-pc-linux-gnu-ranlib... x86_64-pc-linux-gnu-ranlib
checking for a BSD-compatible install... /usr/lib/portage/python3.10/ebuild-helpers/xattr/install -c
checking whether static linking is possible... yes
using max size for mmap-ing known database: 10485760 bytes
checking for dirent.h that defines DIR... yes
checking for library containing opendir... none required
checking for stdio.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for strings.h... yes
checking for sys/stat.h... yes
checking for sys/types.h... yes
checking for unistd.h... yes
checking for sys/param.h... yes
checking for utime.h... yes
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for sys/wait.h that is POSIX.1 compatible... yes
checking for fcntl.h... yes
checking for limits.h... yes
checking for sys/time.h... yes
checking for syslog.h... yes
checking for unistd.h... (cached) yes
checking for utime.h... (cached) yes
checking for stdint.h... (cached) yes
checking for inttypes.h... (cached) yes
checking for an ANSI C-conforming const... yes
checking for inline... inline
checking for mode_t... yes
checking for off_t... yes
checking for size_t... yes
checking for long long... yes
checking for unsigned long long... yes
checking for __FUNCTION__ symbol... yes
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... no
checking endianess... little
checking for byte typedef... no
checking for ushort typedef... yes
checking for ulong typedef... yes
checking for u16 typedef... no
checking for u32 typedef... no
checking size of unsigned short... 2
checking size of unsigned int... 4
checking size of unsigned long... 8
checking size of long long... 8
checking size of unsigned long long... 8
checking for stdint.h... (cached) yes
checking for inttypes.h... (cached) yes
checking for working memcmp... yes
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking for getpagesize... yes
checking for vprintf... yes
checking for working mmap... yes
checking whether lstat correctly handles trailing slash... yes
checking whether lstat accepts an empty string... no
checking for GNU libc compatible malloc... yes
checking for strftime... yes
checking return type of signal handlers... void
checking whether utime accepts a null argument... yes
checking for mkdir... yes
checking for strerror... yes
checking for strstr... yes
checking for memmove... yes
checking for memset... yes
checking for munmap... yes
checking for strchr... yes
checking for strerror... (cached) yes
checking for strrchr... yes
checking for strspn... yes
checking for strstr... (cached) yes
checking for utime... yes
configure: creating ./config.status
config.status: creating Makefile
config.status: creating utils/Makefile
config.status: creating doc/Makefile
config.status: WARNING: 'doc/Makefile.in' seems to ignore the --datarootdir setting
config.status: creating doc/integrit.1
config.status: creating doc/i-viewdb.1
config.status: creating doc/i-ls.1
config.status: creating doc/integrit.texi
config.status: creating config.h
=== configuring in hashtbl (/var/tmp/portage/app-admin/integrit-4.2_rc1/work/integrit-4.2-rc1/hashtbl)
configure: running /bin/sh ./configure --disable-option-checking '--prefix=/usr' '--build=x86_64-pc-linux-gnu' '--host=x86_64-pc-linux-gnu' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib' '--datarootdir=/usr/share' '--docdir=/usr/share/doc/integrit-4.2_rc1' '--htmldir=/usr/share/doc/integrit-4.2_rc1/html' '--libdir=/usr/lib64' 'build_alias=x86_64-pc-linux-gnu' 'host_alias=x86_64-pc-linux-gnu' 'CFLAGS=-march=native -O2 -pipe -frecord-gcc-switches' 'LDFLAGS=-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0' --cache-file=/dev/null --srcdir=.
checking for x86_64-pc-linux-gnu-gcc... x86_64-pc-linux-gnu-gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C... yes
checking whether x86_64-pc-linux-gnu-gcc accepts -g... yes
checking for x86_64-pc-linux-gnu-gcc option to enable C11 features... none needed
checking for x86_64-pc-linux-gnu-ar... x86_64-pc-linux-gnu-ar
checking the archiver (x86_64-pc-linux-gnu-ar) interface... ar
checking whether make sets $(MAKE)... yes
checking for x86_64-pc-linux-gnu-ranlib... x86_64-pc-linux-gnu-ranlib
checking for __FUNCTION__ symbol... yes
checking for inline... inline
checking for a BSD-compatible install... /usr/lib/portage/python3.10/ebuild-helpers/xattr/install -c
checking for stdio.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for strings.h... yes
checking for sys/stat.h... yes
checking for sys/types.h... yes
checking for unistd.h... yes
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for unistd.h... (cached) yes
checking for limits.h... yes
checking for stdint.h... (cached) yes
checking for inttypes.h... (cached) yes
checking for an ANSI C-conforming const... yes
checking for size_t... yes
checking size of unsigned short... 2
checking size of unsigned int... 4
checking size of unsigned long... 8
checking size of unsigned long long... 8
checking for stdint.h... (cached) yes
checking for inttypes.h... (cached) yes
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking for GNU libc compatible malloc... yes
checking for strerror... yes
checking for system dictionary... no
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... no
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
>>> Source configured.
>>> Compiling source in /var/tmp/portage/app-admin/integrit-4.2_rc1/work/integrit-4.2-rc1 ...
make -j16
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o main.o -c ./main.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o options.o -c ./options.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o xml.o -c ./xml.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o eachfile.o -c ./eachfile.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o rules.o -c ./rules.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o checkset.o -c ./checkset.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o missing.o -c ./missing.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o xstrdup.o -c ./xstrdup.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o cdb_put.o -c ./cdb_put.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o cdb_get.o -c ./cdb_get.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o elcwft.o -c ./elcwft.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o cdb.o -c ./cdb.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o cdb_make.o -c ./cdb_make.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o cdb_hash.o -c ./cdb_hash.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o elcerror.o -c ./elcerror.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o cdb_seq.o -c ./cdb_seq.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o hexprint.o -c ./hexprint.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o xstradd.o -c ./xstradd.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o show.o -c ./show.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o rmd160.o -c ./gnupg/rmd160.c
x86_64-pc-linux-gnu-gcc -I. -I. -I./hashtbl -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o istat.o -c ./istat.c
>>> making the hashtbl library: cd hashtbl && make
make[1]: Entering directory '/var/tmp/portage/app-admin/integrit-4.2_rc1/work/integrit-4.2-rc1/hashtbl'
x86_64-pc-linux-gnu-gcc -I. -I. -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o hashtbl.o -c ./hashtbl.c
x86_64-pc-linux-gnu-gcc -I. -I. -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o hfree.o -c ./hfree.c
x86_64-pc-linux-gnu-gcc -I. -I. -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o hgrow.o -c ./hgrow.c
x86_64-pc-linux-gnu-gcc -I. -I. -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o hhash.o -c ./hhash.c
x86_64-pc-linux-gnu-gcc -I. -I. -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o hforeach.o -c ./hforeach.c
x86_64-pc-linux-gnu-ar r libhashtbl.a hashtbl.o hfree.o hgrow.o hhash.o hforeach.o
x86_64-pc-linux-gnu-ar: creating libhashtbl.a
x86_64-pc-linux-gnu-ranlib libhashtbl.a
make[1]: Leaving directory '/var/tmp/portage/app-admin/integrit-4.2_rc1/work/integrit-4.2-rc1/hashtbl'
x86_64-pc-linux-gnu-ar r libintegrit.a elcerror.o cdb_seq.o hexprint.o xstradd.o show.o rmd160.o istat.o
x86_64-pc-linux-gnu-ar: creating libintegrit.a
x86_64-pc-linux-gnu-ranlib libintegrit.a
x86_64-pc-linux-gnu-gcc -L. -Lhashtbl -static -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -o integrit main.o options.o xml.o eachfile.o rules.o checkset.o missing.o xstrdup.o cdb_put.o cdb_get.o elcwft.o cdb.o cdb_make.o cdb_hash.o -lhashtbl -lintegrit
make -j16 utils
>>> making auxiliary tools: cd utils && make
make[1]: Entering directory '/var/tmp/portage/app-admin/integrit-4.2_rc1/work/integrit-4.2-rc1/utils'
x86_64-pc-linux-gnu-gcc -I.. -I./.. -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o viewdb.o -c ./viewdb.c
x86_64-pc-linux-gnu-gcc -I.. -I./.. -march=native -O2 -pipe -frecord-gcc-switches -DHAVE_CONFIG_H -o ls.o -c ./ls.c
x86_64-pc-linux-gnu-gcc -L.. -static -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -o i-viewdb viewdb.o -lintegrit
x86_64-pc-linux-gnu-gcc -L.. -static -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -o i-ls ls.o -lintegrit
make[1]: Leaving directory '/var/tmp/portage/app-admin/integrit-4.2_rc1/work/integrit-4.2-rc1/utils'
make -j16 -C doc
make: Entering directory '/var/tmp/portage/app-admin/integrit-4.2_rc1/work/integrit-4.2-rc1/doc'
makeinfo -o ./integrit.info ./integrit.texi
make: makeinfo: No such file or directory
make: *** [Makefile:92: info] Error 127
make: Leaving directory '/var/tmp/portage/app-admin/integrit-4.2_rc1/work/integrit-4.2-rc1/doc'
* ERROR: app-admin/integrit-4.2_rc1::gentoo failed (compile phase):
* emake failed
added 2 commits
December 20, 2021 14:38
Summary: Bump to EAPI 8 (tested before push) Integrit-4.0 does not exist anymore and now it compiles correctly so I'm gonna close the bug below. Add myself as maintainer Drop old version Closes: https://bugs.gentoo.org/450752 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Marco Scardovi <marco@scardovi.com>
Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Marco Scardovi <marco@scardovi.com>
Could you try to build with -j4? Because it compiles just fine here |
|
Oh, probably is because of a missing texinfo |
Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Marco Scardovi <marco@scardovi.com>
Pull request CI reportReport generated at: 2021-12-20 13:55 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
I think it depends on the complexity of the ebuild & number of eclasses used, and so on. Most of the time, it just leads to stablerot as we forget to call for stabilisation (especially for m-n or otheriwse unmaintained packages). And then it's a waste of arch tester time to make them test it on a bunch of arches. Maybe it's a good idea to expect proxied maintainers to revbump for safety though. This is why it's best to at least try bundle in any other fixes needed (like build system revamps and so on) if we must. devmanual does say "unless trivial" (which you know as you wrote that bit IIRC). At best, it should be ALLARCHES stabled by the person who did it within a few weeks.
Missing BDEPEND on texinfo? |
juippis
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
S="${WORKDIR}/${PN}-${MY_PV}"
PATCHES=( "${FILESDIR}/${PN}"-4.1-fix-build-system.patch )
BDEPEND="sys-apps/texinfo"
These are bit "out of position" but I don't mind it too much. You can make a new PR putting them in place if you wish.
https://github.com/gentoo/gentoo/blob/master/skel.ebuild
(
S under SRC_URI,
I usually place PATCHES right before any phase functions as a last global variable
)
ghost
deleted the
I'll do it on next release or do you prefer it rn, maintaining the same revbump? |
|
Next time you touch the ebuild is fine for me. Definitely don't revbump for cosmetic changes like that :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Bump to EAPI 8 (tested before push)
Integrit-4.0 does not exist anymore and now it compiles correctly so I'm gonna clos the bug below
Add myself as maintainer
Drop old version
Closes: https://bugs.gentoo.org/450752
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Marco Scardovi marco@scardovi.com