Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-misc/seafile{,-cilent}: version bump to 8.0.5 #23430

Closed
wants to merge 2 commits into from

Conversation

CaseOf
Copy link
Contributor

@CaseOf CaseOf commented Dec 20, 2021

No description provided.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @CaseOf
Areas affected: ebuilds
Packages affected: net-misc/seafile, net-misc/seafile-client

net-misc/seafile: @CaseOf, @gentoo/proxy-maint
net-misc/seafile-client: @CaseOf, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Dec 20, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-12-20 12:40 UTC
Newest commit scanned: de0514a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/62058653bb/output.html

Copy link
Contributor

@ionenwks ionenwks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this is based on older ebuilds, missing the changes from f77c7b3 and 129e57f

May be good to cleanup some old versions too? Unless some reason to keep.

Comment on lines +45 to +51
src_configure() {
local myeconfargs=(
--disable-static
)
econf "${myeconfargs[@]}"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if update ebuild to EAPI-8, this can be dropped given --disable-static is passed by default then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or nevermind this bit, forgot vala.eclass isn't EAPI-8 yet.

Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: Quentin Retornaz <gentoo@retornaz.com>
Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: Quentin Retornaz <gentoo@retornaz.com>
@CaseOf
Copy link
Contributor Author

CaseOf commented Jan 6, 2022

I dont know if it is allowed to add this or not, but I did work on a firejail profile https://gist.github.com/CaseOf/2f12ae0f19c35f6a5a048b49492d13f0

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-01-06 00:12 UTC
Newest commit scanned: af7905d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/af989e86f7/output.html

@gentoo-bot gentoo-bot closed this in 49cdc2f Jan 6, 2022
@ionenwks
Copy link
Contributor

ionenwks commented Jan 6, 2022

Thanks, and sorry PR took so long to be looked at.

I dont know if it is allowed to add this or not, but I did work on a firejail profile https://gist.github.com/CaseOf/2f12ae0f19c35f6a5a048b49492d13f0

Don't have a strong opinion here, although Gentoo isn't really pushing official firejail support. It'd make more sense if the file was coming from upstream rather than add things potential future maintainers won't know how to update/test.

@CaseOf CaseOf deleted the seafile branch March 13, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants