Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-misc/ddccontrol: add 0.6.0 #23434

Closed
wants to merge 2 commits into from
Closed

app-misc/ddccontrol: add 0.6.0 #23434

wants to merge 2 commits into from

Conversation

reagentoo
Copy link
Contributor 

app-misc/ddccontrol: add 0.6.0

Closes: https://bugs.gentoo.org/829719
Signed-off-by: Dmitry Baranov <reagentoo@gmail.com>

app-misc/ddccontrol-db: add 20210812

Closes: https://bugs.gentoo.org/829720
Signed-off-by: Dmitry Baranov <reagentoo@gmail.com>

@reagentoo
app-misc/ddccontrol: add 0.6.0
b3cbf58 
Closes: https://bugs.gentoo.org/829719
Signed-off-by: Dmitry Baranov <reagentoo@gmail.com>
@reagentoo
app-misc/ddccontrol-db: add 20210812
942dc29 
Closes: https://bugs.gentoo.org/829720
Signed-off-by: Dmitry Baranov <reagentoo@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @reagentoo
Areas affected: ebuilds
Packages affected: app-misc/ddccontrol, app-misc/ddccontrol-db

app-misc/ddccontrol: @gentoo/proxy-maint (maintainer needed)
app-misc/ddccontrol-db: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 829720, 829719

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 20, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-12-20 17:25 UTC
Newest commit scanned: 942dc29
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2c18ecdd0f/output.html

@reagentoo
Copy link
Contributor Author

@juippis do we need to bump EAPI?

@juippis
Copy link
Member

juippis commented Jan 10, 2022

I already have, will fix-on-merge. Thanks for noticing though!

thesamesam
thesamesam reviewed Jan 10, 2022
View reviewed changes
app-misc/ddccontrol-db/ddccontrol-db-20210812.ebuild

RDEPEND="nls? ( sys-devel/gettext )"
DEPEND="${RDEPEND}
dev-util/intltool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BDEPEND, usually.

thesamesam
thesamesam reviewed Jan 10, 2022
View reviewed changes
app-misc/ddccontrol/ddccontrol-0.6.0.ebuild
dev-perl/XML-Parser
dev-util/intltool
sys-kernel/linux-headers
doc? (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least intltool (probably) and the doc? bit are BDEPEND (we call binaries they install to generate documentation or translations)

thesamesam
thesamesam reviewed Jan 10, 2022
View reviewed changes
app-misc/ddccontrol/ddccontrol-0.6.0.ebuild
## Save for a rainy day or future patching
touch config.rpath ABOUT-NLS
eautoreconf
intltoolize --force || die "intltoolize failed"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh.. not sure this is even needed anymore (diff before/after) but if it is, build system patch is likely better.

@juippis
Copy link
Member

juippis commented Jan 10, 2022 •
edited

e4d323e
94a0475
Here are the "fix" commits - if I missed anything, let me know @thesamesam !

EDIT: BDEPEND="${RDEPEND} ahh well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam thesamesam left review comments

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
5 participants
@reagentoo @gentoo-bot @gentoo-repo-qa-bot @juippis @thesamesam