Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-java/netty-buffer: Java heap space #23627

Closed
wants to merge 1 commit into from

Conversation

vaukai
Copy link
Contributor

@vaukai vaukai commented Jan 2, 2022

"OutOfMemoryError: Java heap space" could be reproduced
with CHECKREQS_MEMORY="512M". Setting now to "2048M".
Closes: https://bugs.gentoo.org/829822

Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: Volkmar W. Pogatzki gentoo@pogatzki.net

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @vaukai
Areas affected: ebuilds
Packages affected: dev-java/netty-buffer

dev-java/netty-buffer: @gentoo/java

Linked bugs

Bugs linked: 829822


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 2, 2022
@fordfrog
Copy link
Contributor

fordfrog commented Jan 3, 2022

if it's only fix of failing tests then no need to revbump. i did not check all the changes and github does not show that to me so not sure whether this is the only change.

@vaukai
Copy link
Contributor Author

vaukai commented Jan 3, 2022

if it's only fix of failing tests then no need to revbump. i did not check all the changes and github does not show that to me so not sure whether this is the only change.

It was also for some minor style updates but not really worth the revbump. Thanks for the review.

@fordfrog
Copy link
Contributor

fordfrog commented Jan 4, 2022

now when i see the changes it really needs a revbump. there's the change in eapi version, looks like deps have been updated, min java version...

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-01-04 09:10 UTC
Newest commit scanned: 94984f4
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/301860dc6c/output.html

@vaukai
Copy link
Contributor Author

vaukai commented Jan 7, 2022

now when i see the changes it really needs a revbump. there's the change in eapi version, looks like deps have been updated, min java version...

Revbumped. Should help getting rid of older dom4j versions ...

@Flowdalic
Copy link
Member

I would appreciate a better commit subject. if I am reading the message right, then the subject could be "dev-java/netty-buffer: increase heap to 2048M for tests". I am also not sure why check_env() isn't simply inlined in src_test()? Then CHECKREQS_MEMORY could become a local variable, not cluttering the globals.

"OutOfMemoryError: Java heap space" could be reproduced
with CHECKREQS_MEMORY="512M". Setting now to "2048M".
Closes: https://bugs.gentoo.org/829822
Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@vaukai
Copy link
Contributor Author

vaukai commented Jan 7, 2022

I would appreciate a better commit subject. if I am reading the message right, then the subject could be "dev-java/netty-buffer: increase heap to 2048M for tests".

Commit message adjusted to proposal.

I am also not sure why check_env() isn't simply inlined in src_test()? Then CHECKREQS_MEMORY could become a local variable, not cluttering the globals.

This coding is simply taken over from what's used in dev-java/bcprov.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-01-07 17:30 UTC
Newest commit scanned: ec2f835
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d67bf38091/output.html

@Flowdalic
Copy link
Member

This coding is simply taken over from what's used in dev-java/bcprov.

Ahh, now I also see that this is due check-reqs eclass.

@gentoo-bot gentoo-bot closed this in afbd005 Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
5 participants