Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead impls #23649

Closed
wants to merge 2 commits into from
Closed

Remove dead impls #23649

wants to merge 2 commits into from

Conversation

SoapGentoo
Copy link
Member

No description provided.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @SoapGentoo
Areas affected: ebuilds, eclasses, profiles
Packages affected: dev-db/postgresql

dev-db/postgresql: @gentoo/postgresql

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jan 4, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-01-04 16:20 UTC
Newest commit scanned: 7d77083
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2055ce26ad/output.html

@a17r a17r requested a review from Pesa January 4, 2022 20:05
SoapGentoo
SoapGentoo commented Jan 4, 2022
View reviewed changes
eclass/qt5-build.eclass Outdated
elif tc-is-clang; then
echo -platform freebsd-clang
fi
fi)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pesa ok to remove this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Pesa
Pesa approved these changes Jan 4, 2022
View reviewed changes
eclass/qt5-build.eclass Outdated
elif tc-is-clang; then
echo -platform freebsd-clang
fi
fi)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-01-04 21:10 UTC
Newest commit scanned: 5288854
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/621e0ef6d4/output.html

grobian
grobian approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@grobian grobian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-01-05 10:45 UTC
Newest commit scanned: 0923606
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fed84a5e69/output.html

@SoapGentoo
profiles: remove dead kernel/elibc flags
6b06ca9 
Signed-off-by: David Seifert <soap@gentoo.org>
@SoapGentoo
profiles: remove amd64-fbsd/x86-fbsd keywords
0664c32 
Signed-off-by: David Seifert <soap@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-01-06 10:06 UTC
Newest commit scanned: 0664c32
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1c8c8d30bb/output.html

@gentoo-bot gentoo-bot closed this in 82a7903 Jan 6, 2022
@SoapGentoo SoapGentoo deleted the remove-dead-impls branch January 6, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pesa Pesa Pesa approved these changes

@grobian grobian grobian approved these changes

@thesamesam thesamesam thesamesam approved these changes

@a17r a17r Awaiting requested review from a17r

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
6 participants
@SoapGentoo @gentoo-bot @gentoo-repo-qa-bot @Pesa @grobian @thesamesam