New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
media-plugins/vdr-streamdev: version bump to 0.6.3 #23960
Conversation
Pull Request assignmentSubmitter: @madmartin media-plugins/vdr-streamdev: @gentoo/vdr Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2022-01-26 07:22 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
DEPEND=">=media-video/vdr-2.3" | ||
RDEPEND="${DEPEND}" | ||
|
||
QA_FLAGS_IGNORED=" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this stuff prebuilt or not? Why do we need to set QA_FLAGS_IGNORED?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All packages media-plugins/vdr-* are build with the CFLAGS taken from the BDEPENDed media-video/vdr. This may result into a QA message that this package is ignoring the current CFLAGS.
Copying the CFLAGS from main vdr package is necessary to asssure that the plugins (libraries) match exactly.
Pull request CI reportReport generated at: 2022-06-25 16:46 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* QA Notice: Plugin isn't converted to gettext handling!
* QA Notice: Fixing include of libsi-headers
is this a problem? Looks good otherwise, but see the comment about acct* deps.
BDEPEND="acct-user/vdr" | ||
DEPEND=">=media-video/vdr-2.3" | ||
RDEPEND="${DEPEND}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put the acct-* deps in DEPEND that also gets inherited by RDEPEND. Both of them.
Both no. "gettext" handling is the newer/current way to handle i18n, before vdr-1.7.something there was a static array solution for translated strings. Some plugin authors still have not updated their stuff yet. The "libsi-headers" notice I cannot 100% explain - i think the libsi.h include path is different in gentoo from upstream vdr, so all plugins must be adjusted. Both notices come from |
new EAPI 8 make USE=server the default adopt proxy maintainership change HOME due to retirement of http://projects.vdr-developer.org Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
@juippis now changed to DEPEND="acct-user/vdr |
Pull request CI reportReport generated at: 2022-06-28 11:45 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
DEPEND="acct-user/vdr | ||
>=media-video/vdr-2.3" | ||
BDEPEND="${DEPEND}" | ||
RDEPEND="${DEPEND}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100 % sure about this either, but at least it's more correct now! And this could perfectly well be how it's supposed to be, I just haven't studied vdr enough to tell.
new EAPI 8
make USE=server the default
adopt proxy maintainership
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Martin Dummer martin.dummer@gmx.net