Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-plugins/vdr-streamdev: version bump to 0.6.3 #23960

Closed
wants to merge 1 commit into from

Conversation

madmartin
Copy link
Contributor

new EAPI 8
make USE=server the default
adopt proxy maintainership

Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Martin Dummer martin.dummer@gmx.net

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @madmartin
Areas affected: ebuilds
Packages affected: media-plugins/vdr-streamdev

media-plugins/vdr-streamdev: @gentoo/vdr

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jan 25, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-01-26 07:22 UTC
Newest commit scanned: 4e7e1e1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a57738986c/output.html

DEPEND=">=media-video/vdr-2.3"
RDEPEND="${DEPEND}"

QA_FLAGS_IGNORED="
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this stuff prebuilt or not? Why do we need to set QA_FLAGS_IGNORED?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All packages media-plugins/vdr-* are build with the CFLAGS taken from the BDEPENDed media-video/vdr. This may result into a QA message that this package is ignoring the current CFLAGS.
Copying the CFLAGS from main vdr package is necessary to asssure that the plugins (libraries) match exactly.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-06-25 16:46 UTC
Newest commit scanned: 4af04a1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0762165b70/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 * QA Notice: Plugin isn't converted to gettext handling!
 * QA Notice: Fixing include of libsi-headers

is this a problem? Looks good otherwise, but see the comment about acct* deps.

Comment on lines 19 to 22
BDEPEND="acct-user/vdr"
DEPEND=">=media-video/vdr-2.3"
RDEPEND="${DEPEND}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put the acct-* deps in DEPEND that also gets inherited by RDEPEND. Both of them.

@madmartin
Copy link
Contributor Author

 * QA Notice: Plugin isn't converted to gettext handling!
 * QA Notice: Fixing include of libsi-headers

is this a problem

Both no. "gettext" handling is the newer/current way to handle i18n, before vdr-1.7.something there was a static array solution for translated strings. Some plugin authors still have not updated their stuff yet.

The "libsi-headers" notice I cannot 100% explain - i think the libsi.h include path is different in gentoo from upstream vdr, so all plugins must be adjusted.

Both notices come from vdr-plugin-2.eclass, and on next review of the eclass the "Fixing include of libsi-headers" can be changed from eqawarn to einfo.

new EAPI 8
make USE=server the default
adopt proxy maintainership
change HOME due to retirement of http://projects.vdr-developer.org

Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
@madmartin
Copy link
Contributor Author

@juippis now changed to

DEPEND="acct-user/vdr
>=media-video/vdr-2.3"
BDEPEND="${DEPEND}"
RDEPEND="${DEPEND}"

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-06-28 11:45 UTC
Newest commit scanned: 9b94af5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f4fe2fddbd/output.html

@madmartin madmartin requested a review from juippis June 28, 2022 13:48
Comment on lines +19 to +22
DEPEND="acct-user/vdr
>=media-video/vdr-2.3"
BDEPEND="${DEPEND}"
RDEPEND="${DEPEND}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100 % sure about this either, but at least it's more correct now! And this could perfectly well be how it's supposed to be, I just haven't studied vdr enough to tell.

@madmartin madmartin deleted the streamdev branch June 28, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
5 participants