gnome-extra/gnome-commander: add version 1.14.0 #24092

turboscholz · 2022-02-05T20:51:37Z

This version removes the dependency from gnome-vfs.

Also, the changelog URL is corrected in the metadata.xml file.

gentoo-bot · 2022-02-05T20:52:06Z

Pull Request assignment

Submitter: @turboscholz
Areas affected: ebuilds
Packages affected: gnome-extra/gnome-commander

gnome-extra/gnome-commander: @turboscholz, @gentoo/proxy-maint

Linked bugs

Bugs linked: 751001

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2022-02-05T21:15:54Z

Pull request CI report

Report generated at: 2022-02-05 21:15 UTC
Newest commit scanned: 1440da8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c9d3c6375f/output.html

a17r · 2022-02-05T21:15:30Z

gnome-extra/gnome-commander/gnome-commander-1.14.0.ebuild

+# Copyright 1999-2022 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=7


What about EAPI-8?

I will check. Why does repoman -dx full does not complain? This would be a nice feature. ;-)

It will start complaining about it once EAPI-7 becomes deprecated - we are quite some time away from that, but no reason to wait for porting either. ;)

gnome-extra/gnome-commander/gnome-commander-1.14.0.ebuild

a17r · 2022-02-05T21:16:33Z

gnome-extra/gnome-commander/gnome-commander-1.14.0.ebuild

+	sys-devel/gettext
+	virtual/pkgconfig
+"
+DEPEND="


This is likely where you wanted to put RDEPEND (instead of above).

mattst88 · 2022-02-05T21:38:50Z

gnome-extra/gnome-commander/gnome-commander-1.14.0.ebuild

+RESTRICT="!test? ( test )"
+
+RDEPEND="
+	app-text/yelp-tools


yelp-tools should likely be in BDEPEND.

mattst88 · 2022-02-05T21:39:04Z

gnome-extra/gnome-commander/gnome-commander-1.14.0.ebuild

+
+RDEPEND="
+	app-text/yelp-tools
+	dev-libs/atk


I see no evidence that this dependency is correct.

there was this commit c32dfd8 from @juippis where this dependency was added. I did not find the time to check why this was done, maybe he can comment. But I agree that it can be removed. Same holds true for the other additional packages you mentioned. Thanks for bringing it up.

grep -i atk /var/db/pkg/gnome-extra/gnome-commander-1.14.0/NEEDED.ELF.2
X86_64;/usr/lib64/gnome-commander/plugins/libfileroller.so;libfileroller.so;;libgtk-x11-2.0.so.0,libgdk-x11-2.0.so.0,libpangocairo-1.0.so.0,libatk-1.0.so.0,libcairo.so.2,libgdk_pixbuf-2.0.so.0,libgio-2.0.so.0,libpangoft2-1.0.so.0,libpango-1.0.so.0,libgobject-2.0.so.0,libglib-2.0.so.0,libharfbuzz.so.0,libfontconfig.so.1,libfreetype.so.6,libstdc++.so.6,libc.so.6,libgcc_s.so.1;x86_64

scanelf -n /usr/lib64/gnome-commander/plugins/libfileroller.so
TYPE NEEDED FILE
ET_DYN libgtk-x11-2.0.so.0,libgdk-x11-2.0.so.0,libpangocairo-1.0.so.0,libatk-1.0.so.0,libcairo.so.2,libgdk_pixbuf-2.0.so.0,libgio-2.0.so.0,libpangoft2-1.0.so.0,libpango-1.0.so.0,libgobject-2.0.so.0,libglib-2.0.so.0,libharfbuzz.so.0,libfontconfig.so.1,libfreetype.so.6,libstdc++.so.6,libc.so.6,libgcc_s.so.1 /usr/lib64/gnome-commander/plugins/libfileroller.so

Hi! It took a while but since yesterday, gnome-commander-1.16.0 is in portage which does not have this issue with that many linked libraries anymore - as the program uses Meson now. Example:

$ scanelf -n /usr/lib64/gnome-commander/plugins/libfilerollerplugin.so TYPE NEEDED FILE ET_DYN libglib-2.0.so.0,libgio-2.0.so.0,libgobject-2.0.so.0,libgtk-x11-2.0.so.0,libgdk_pixbuf-2.0.so.0,libstdc++.so.6,libgcc_s.so.1,libc.so.6 /usr/lib64/gnome-commander/plugins/libfilerollerplugin.so

I'm happy 😃

mattst88 · 2022-02-05T21:39:44Z

gnome-extra/gnome-commander/gnome-commander-1.14.0.ebuild

+RDEPEND="
+	app-text/yelp-tools
+	dev-libs/atk
+	dev-libs/glib:2


Should be >=dev-libs/glib-2.70.0:2. The dependency in configure.ac is 2.66, but there's an additional check for 2.70, so just require that since it's already stable.

mattst88 · 2022-02-05T21:39:53Z

gnome-extra/gnome-commander/gnome-commander-1.14.0.ebuild

+	app-text/yelp-tools
+	dev-libs/atk
+	dev-libs/glib:2
+	gnome-base/gconf:2


I see no evidence this is required.

mattst88 · 2022-02-05T21:40:02Z

gnome-extra/gnome-commander/gnome-commander-1.14.0.ebuild

+	dev-libs/atk
+	dev-libs/glib:2
+	gnome-base/gconf:2
+	media-libs/fontconfig


I see no evidence this is required.

X86_64;/usr/lib64/gnome-commander/plugins/libfileroller.so;libfileroller.so;;libgtk-x11-2.0.so.0,libgdk-x11-2.0.so.0,libpangocairo-1.0.so.0,libatk-1.0.so.0,libcairo.so.2,libgdk_pixbuf-2.0.so.0,libgio-2.0.so.0,libpangoft2-1.0.so.0,libpango-1.0.so.0,libgobject-2.0.so.0,libglib-2.0.so.0,libharfbuzz.so.0,libfontconfig.so.1,libfreetype.so.6,libstdc++.so.6,libc.so.6,libgcc_s.so.1;x86_64

TYPE NEEDED FILE
ET_DYN libgtk-x11-2.0.so.0,libgdk-x11-2.0.so.0,libpangocairo-1.0.so.0,libatk-1.0.so.0,libcairo.so.2,libgdk_pixbuf-2.0.so.0,libgio-2.0.so.0,libpangoft2-1.0.so.0,libpango-1.0.so.0,libgobject-2.0.so.0,libglib-2.0.so.0,libharfbuzz.so.0,libfontconfig.so.1,libfreetype.so.6,libstdc++.so.6,libc.so.6,libgcc_s.so.1 /usr/lib64/gnome-commander/plugins/libfileroller.so

mattst88 · 2022-02-05T21:42:08Z

gnome-extra/gnome-commander/gnome-commander-1.14.0.ebuild

+	x11-libs/cairo
+	x11-libs/gdk-pixbuf:2
+	x11-libs/gtk+:2
+	x11-libs/pango


I see calls to pango_ functions, but no #includes of pango headers nor checks in configure.ac for pango.

I see pango being linked to final libraries and binaries.

X86_64;/usr/lib64/gnome-commander/plugins/libfileroller.so;libfileroller.so;;libgtk-x11-2.0.so.0,libgdk-x11-2.0.so.0,libpangocairo-1.0.so.0,libatk-1.0.so.0,libcairo.so.2,libgdk_pixbuf-2.0.so.0,libgio-2.0.so.0,libpangoft2-1.0.so.0,libpango-1.0.so.0,libgobject-2.0.so.0,libglib-2.0.so.0,libharfbuzz.so.0,libfontconfig.so.1,libfreetype.so.6,libstdc++.so.6,libc.so.6,libgcc_s.so.1;x86_64
X86_64;/usr/bin/gnome-commander;;/usr/lib64/gnome-commander;libgcmd.so.0,libgmodule-2.0.so.0,libunique-1.0.so.0,libgtk-x11-2.0.so.0,libgdk-x11-2.0.so.0,libgdk_pixbuf-2.0.so.0,libgio-2.0.so.0,libpango-1.0.so.0,libexiv2.so.27,libgsf-1.so.114,libgobject-2.0.so.0,libglib-2.0.so.0,libstdc++.so.6,libm.so.6,libgcc_s.so.1,libc.so.6;x86_64

mattst88 · 2022-02-05T21:43:42Z

gnome-extra/gnome-commander/gnome-commander-1.14.0.ebuild

+	x11-libs/gdk-pixbuf:2
+	x11-libs/gtk+:2
+	x11-libs/pango
+	chm? ( dev-libs/chmlib )


This does nothing. I've made a PR to remove the configure.ac logic upstream: https://gitlab.gnome.org/GNOME/gnome-commander/-/merge_requests/27

mattst88 · 2022-02-05T21:44:19Z

gnome-extra/gnome-commander/gnome-commander-1.14.0.ebuild

+	x11-libs/pango
+	chm? ( dev-libs/chmlib )
+	exif? ( >=media-gfx/exiv2-0.14 )
+	gsf? ( gnome-extra/libgsf:= )


Should be gsf? ( >=gnome-extra/libgsf-1.12:= )

mattst88 · 2022-02-05T21:45:07Z

gnome-extra/gnome-commander/gnome-commander-1.14.0.ebuild

+"
+BDEPEND="
+	dev-util/gtk-doc-am
+	sys-devel/gettext


Should be >=sys-devel/gettext-0.19.7

only available in portage is 0.21, do you really think the explicit version is needed?

In general we keep minimum version reqs until after some time (2 years) they have left the tree. gnome proj may have different standards.

Yeah, I don't really have a preference. I guess it just seems easier to put the version in so you don't have to think about it. 🤷

Updated, along with the addition of sys-devel/flex

mattst88 · 2022-02-05T21:45:35Z

gnome-extra/gnome-commander/gnome-commander-1.14.0.ebuild

+src_configure() {
+	gnome2_src_configure \
+		--disable-static \
+		$(use_with chm libchm) \


Please just pass --without-libchm since the config option does nothing.

gentoo-repo-qa-bot · 2022-02-05T22:06:12Z

Pull request CI report

Report generated at: 2022-02-05 22:06 UTC
Newest commit scanned: 07034b5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/acb8a31ec5/output.html

gentoo-repo-qa-bot · 2022-02-05T23:06:00Z

Pull request CI report

Report generated at: 2022-02-05 23:06 UTC
Newest commit scanned: ac735bc
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c0a90ab334/output.html

juippis · 2022-02-06T09:21:24Z

Also in addition:

configure: error: You need the 'flex' lexer generator to compile Gnome Commander

!!! Please attach the following file when seeking support:
!!! /var/tmp/portage/gnome-extra/gnome-commander-1.14.0/work/gnome-commander-1.14.0/config.log
 * ERROR: gnome-extra/gnome-commander-1.14.0::gentoo failed (configure phase):
 *   econf failed

Bug: https://bugs.gentoo.org/751001 Signed-off-by: Uwe Scholz <u.scholz83@gmx.de> Package-Manager: Portage-3.0.28, Repoman-3.0.3

Change the URL to the one in upstream master branch Signed-off-by: Uwe Scholz <u.scholz83@gmx.de>

gentoo-repo-qa-bot · 2022-02-06T10:21:29Z

Pull request CI report

Report generated at: 2022-02-06 10:21 UTC
Newest commit scanned: 43f53cb
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/99a2830817/output.html

juippis

Had this,

/bin/sh: line 1: glib-mkenums: command not found
make[2]: *** [Makefile:695: org.gnome.gnome-commander.enums.xml] Error 127

so I'm going to add glib-utils to BDEPEND. But with that, thanks for your patience! And I hope the efforts of porting to meson will pay off.

turboscholz · 2022-02-09T19:47:56Z

Am Wed, 09 Feb 2022 09:44:23 -0800 schrieb juippis:

@juippis approved this pull request. Had this, ``` /bin/sh: line 1: glib-mkenums: command not found make[2]: *** [Makefile:695: org.gnome.gnome-commander.enums.xml] Error 127 ``` so I'm going to add glib-utils to BDEPEND. But with that, thanks for your patience! And I hope the efforts of porting to meson will pay off.

Thank's a lot for the findings!

gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Feb 5, 2022

a17r suggested changes Feb 5, 2022

View reviewed changes

turboscholz force-pushed the master branch from 1440da8 to 07034b5 Compare February 5, 2022 21:42

mattst88 suggested changes Feb 5, 2022

View reviewed changes

turboscholz force-pushed the master branch from 8d1e890 to ac735bc Compare February 5, 2022 22:54

turboscholz force-pushed the master branch from 07034b5 to 8d1e890 Compare February 5, 2022 23:24

turboscholz added 2 commits February 6, 2022 11:08

gnome-extra/gnome-commander: add version 1.14.0

66be8fa

Bug: https://bugs.gentoo.org/751001 Signed-off-by: Uwe Scholz <u.scholz83@gmx.de> Package-Manager: Portage-3.0.28, Repoman-3.0.3

gnome-extra/gnome-commander: Change changelog url

43f53cb

Change the URL to the one in upstream master branch Signed-off-by: Uwe Scholz <u.scholz83@gmx.de>

turboscholz force-pushed the master branch from ac735bc to 43f53cb Compare February 6, 2022 10:08

juippis approved these changes Feb 9, 2022

View reviewed changes

gentoo-bot closed this in 9723905 Feb 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gnome-extra/gnome-commander: add version 1.14.0 #24092

gnome-extra/gnome-commander: add version 1.14.0 #24092

turboscholz commented Feb 5, 2022

gentoo-bot commented Feb 5, 2022

gentoo-repo-qa-bot commented Feb 5, 2022

a17r Feb 5, 2022

turboscholz Feb 5, 2022 •

edited

a17r Feb 5, 2022

turboscholz Feb 5, 2022

a17r Feb 5, 2022

mattst88 Feb 5, 2022

mattst88 Feb 5, 2022

turboscholz Feb 5, 2022 •

edited

juippis Feb 6, 2022

turboscholz Jan 23, 2023

mattst88 Feb 5, 2022

mattst88 Feb 5, 2022

mattst88 Feb 5, 2022

juippis Feb 6, 2022

mattst88 Feb 5, 2022

juippis Feb 6, 2022

mattst88 Feb 5, 2022

mattst88 Feb 5, 2022

mattst88 Feb 5, 2022

turboscholz Feb 5, 2022 •

edited

a17r Feb 5, 2022

mattst88 Feb 6, 2022

turboscholz Feb 6, 2022

mattst88 Feb 5, 2022

gentoo-repo-qa-bot commented Feb 5, 2022

gentoo-repo-qa-bot commented Feb 5, 2022

juippis commented Feb 6, 2022

gentoo-repo-qa-bot commented Feb 6, 2022

juippis left a comment

turboscholz commented Feb 9, 2022 via email

gnome-extra/gnome-commander: add version 1.14.0 #24092

gnome-extra/gnome-commander: add version 1.14.0 #24092

Conversation

turboscholz commented Feb 5, 2022

gentoo-bot commented Feb 5, 2022

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented Feb 5, 2022

Pull request CI report

Choose a reason for hiding this comment

turboscholz Feb 5, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

turboscholz Feb 5, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

turboscholz Feb 5, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Feb 5, 2022

Pull request CI report

gentoo-repo-qa-bot commented Feb 5, 2022

Pull request CI report

juippis commented Feb 6, 2022

gentoo-repo-qa-bot commented Feb 6, 2022

Pull request CI report

juippis left a comment

Choose a reason for hiding this comment

turboscholz commented Feb 9, 2022 via email

turboscholz Feb 5, 2022 •

edited

turboscholz Feb 5, 2022 •

edited

turboscholz Feb 5, 2022 •

edited