net-misc/balance: add net_bind_service capability #24325
Conversation
gentoo-bot
added
maintainer-needed
Pull request CI reportReport generated at: 2022-02-23 10:11 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2022-02-23 18:26 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2022-02-23 18:41 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
glorg
force-pushed
the
net-misc-balance-3.57-r1
branch
from
8dc30cf
to
eeff313
Compare
Pull request CI reportReport generated at: 2022-02-23 19:36 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
glorg
force-pushed
the
net-misc-balance-3.57-r1
branch
from
eeff313
to
60d4e6f
Compare
Pull request CI reportReport generated at: 2022-02-23 20:01 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| pkg_postinst() { | ||
| fcaps_pkg_postinst | ||
| elog "To run as non-root, be sure to have rendezvous directory created" | ||
| elog "with either 'mkdir -m 01777 /var/run/balance' or using tmpfiles." |
There was a problem hiding this comment.
I personally don't think this message is necessary here, because balance itself prints following message on start:
ERROR: rendezvous directory not available and/or creatable
please create /var/run/balance/ with mode 01777 like this:
# mkdir -m 01777 /var/run/balance/
But it is probably ok to go with it.
There was a problem hiding this comment.
In case /var/run is on tmpfs and cleaned with reboots, this will point the user on what tool (tmpfiles) to use for solving this problem correctly and what's required for the server to run.
|
I think it would be better to change title of the commit message to somehting like |
glorg
changed the title
This changes binary capabilities and allows binding to privileged ports for non-root Signed-off-by: Eugene Glorg <glorg@railglorg.net>
glorg
force-pushed
the
net-misc-balance-3.57-r1
branch
from
60d4e6f
to
3c0ec7e
Compare
glorg
changed the title
gentoo-bot
changed the title
Pull Request assignmentSubmitter: @glorg net-misc/balance: @gentoo/proxy-maint (maintainer needed) Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
maintainer-needed
Pull request CI reportReport generated at: 2022-02-23 21:21 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| PATCHES=( "${FILESDIR}"/${P}-Makefile.patch ) | ||
|
|
||
| FILECAPS=( | ||
| 'CAP_NET_BIND_SERVICE' '/usr/sbin/balance' |
There was a problem hiding this comment.
I've made this path relative.
This changes binary capabilities and allows binding to privileged ports for non-root