Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-libs/libzip: Add zstd dependency #24343

Closed
wants to merge 1 commit into from

Conversation

semajmail
Copy link
Contributor

The version bump of dev-libs/libzip from 1.7.3 to 1.8.0 included support for zstd and libzip added it as a dependency, however this was missing from the ebuild.

Signed-off-by: Liam Flaherty <liamflaherty@chromium.org>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @semajmail
Areas affected: ebuilds
Packages affected: dev-libs/libzip

dev-libs/libzip: @gentoo/kde

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Feb 25, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-02-25 05:46 UTC
Newest commit scanned: f44c99a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/539109d1da/output.html

@thesamesam
Copy link
Member

Thanks! I've added this with a revbump (git mv in this case) because without it, it'll be an automagic dependency (so if you don't have USE=zstd enabled, even after an emerge -uvDU @world update, you won't rebuild it without zstd support if zstd was installed at time of the original install), and could break e.g. binpkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants