media-fonts/fonts-meta: bump to v2 #24361
Conversation
| LICENSE="metapackage" | ||
| SLOT="0" | ||
| KEYWORDS="~amd64 ~x86" | ||
| IUSE="cjk emoji latin ms" |
There was a problem hiding this comment.
| IUSE="cjk emoji latin ms" | |
| IUSE="cjk emoji +latin ms" |
Pull Request assignmentSubmitter: @juippis media-fonts/fonts-meta: @DarthGandalf, @juippis, @gentoo/fonts Linked bugsBugs linked: 830671 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
Pull request CI reportReport generated at: 2022-02-26 15:16 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| media-fonts/tex-gyre | ||
| media-fonts/ubuntu-font-family | ||
| media-fonts/urw-fonts | ||
| media-libs/fontconfig |
There was a problem hiding this comment.
this doesn't belong to "latin?", and is already dependent unconditionally at the top
There was a problem hiding this comment.
Woops, some copy-paste error.
| media-fonts/font-bh-ttf | ||
| media-fonts/font-cursor-misc | ||
| media-fonts/liberation-fonts | ||
| media-fonts/noto |
There was a problem hiding this comment.
How did you choose which fonts to use? I see you replaced hack and source-pro with other fonts
There was a problem hiding this comment.
That's indeed the hard part. Very much based on the previous ebuild, and "feeling" of "good defaults". This is where I'd like some opinions too. I'd like sane but working defaults, while leaving a lot of "preference" up to user. Hence dropping hack and source-code, they're not "used" by anything and probably aren't even that popular anymore. If we were to add some monospace fonts, I'd much prefer more popular ones, such as anonymous-pro, iosevka, fira whatever.. but I'd really leave this up for users to choose.
Also I'm not so sure about the other "core" fonts listed here. Such as courier-prime, font-bh-ttf, etc...
There was a problem hiding this comment.
My wish for this ebuild is to have a good selection of reasonably popular fonts, and to render all the glyphs correctly, (provided that the correct language USE-flag is set).
I don't know how to measure popularity of fonts. I personally use hack in terminal, and can readd it back to my world file when this PR is merged. Tbh, I thought hack is pretty popular (in my social bubble), so I probably wouldn't remove it yet. But that goes to my preference, ignoring preference of other users.
Maybe install all the popular fonts, and let users choose which font to use among the installed ones? After all, users always have a choice to install the wanted fonts manually, and ignore this meta package if they want to minimize the list of fonts installed
There was a problem hiding this comment.
My wish for this ebuild is to have a good selection of reasonably popular fonts, and to render all the glyphs correctly, (provided that the correct language USE-flag is set).
Yep, agree there.
I don't know how to measure popularity of fonts. I personally use hack in terminal, and can readd it back to my world file when this PR is merged. Tbh, I thought hack is pretty popular (in my social bubble), so I probably wouldn't remove it yet. But that goes to my preference, ignoring preference of other users.
I just googled "popular (monospace) fonts" and hack was rarely represented in those lists.
Maybe install all the popular fonts, and let users choose which font to use among the installed ones?
If I understand you correctly here, that crossed my mind, but I'd rather leave the choice for users to begin with. This way you're not installing 100 fonts where you use 1. This is especially true with monospace fonts.
What do you think about this dirty solution:
|| (
monospace-font-1
monospace-font-2
monospace-font-3
monospace-font-4
)
We'd add this to the very core, or under "latin".
After all, users always have a choice to install the wanted fonts manually, and ignore this meta package if they want to minimize the list of fonts installed
Indeed, but I believe we should attempt to provide reasonable defaults here. I thought about including pretty much ~every font under media-fonts/* in this ebuild one way or another (latin-extras, cjk-extras use flags for example), but it quickly became a stupid idea, since users can choose to install whatever extra they want.
There was a problem hiding this comment.
What do you think about this dirty solution:
That works. In that case the first font in the list should have distinguishable 0Oo, lI1|. Not all fonts you selected for the "new" list satisfy that.
We'd add this to the very core, or under "latin".
I'd say core. Having a monospace font (which is not necessary latin-only) is useful even without fonts specific to latin.
~every font under media-fonts/*
I actually had tried this for a while, the results were bad. Some wild font (don't know which one) was causing rendering issues by declaring that it has all the glyphs, but actually having only some. And there was a case where some programs couldn't decide which font to use to render certain glyphs, and randomly were switching between fonts
juippis
force-pushed
the
fonts-meta-1.1
branch
3 times, most recently
from
ce9a9e2
to
6b30265
Compare
Pull request CI reportReport generated at: 2022-03-03 11:41 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| media-fonts/fantasque-sans-mono | ||
| media-fonts/fira-code | ||
| media-fonts/fira-mono | ||
| media-fonts/fira-sans |
There was a problem hiding this comment.
The package description says this is a monospace font, but it doesn't look like it...
https://mozilla.github.io/Fira/
| media-fonts/fira-sans |
Pull request CI reportReport generated at: 2022-03-03 11:56 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
- add more latin fonts, remove some personally preferred options, - add l10n_ru for a minimal cyrillic support, - combine japan, korean and chinese fonts under 'cjk' for tree consistency, - drop "free" USE flag and provide the "core" fonts under 'latin' USE. May be subject to change. Closes: https://bugs.gentoo.org/830671 Signed-off-by: Joonas Niilola <juippis@gentoo.org>
Pull request CI reportReport generated at: 2022-03-04 14:36 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
consistency,
USE. May be subject to change.
I thought about unconditionally installing the "latin" stuff.