Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-devel/llvm-roc: locate bitcode correctly #24421

Closed
wants to merge 1 commit into from
Closed

sys-devel/llvm-roc: locate bitcode correctly #24421

wants to merge 1 commit into from

Conversation

littlewu2508
Copy link
Contributor

This fixes clang not able to find rocm-device-libs when calling from
rocm-comgr instead of commandline.

Closes: https://bugs.gentoo.org/830762
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Yiyang Wu xgreenlandforwyy@gmail.com

@littlewu2508
sys-devel/llvm-roc: locate bitcode correctly
bd0967a 
This fixes clang not able to find rocm-device-libs when calling from
rocm-comgr instead of commandline.

Closes: https://bugs.gentoo.org/830762
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @littlewu2508
Areas affected: ebuilds
Packages affected: sys-devel/llvm-roc

sys-devel/llvm-roc: @candrews

Linked bugs

Bugs linked: 830762

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 6, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-03-06 14:46 UTC
Newest commit scanned: bd0967a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e26914cc3c/output.html

@heroxbd
Copy link
Contributor

heroxbd commented Mar 20, 2022

Do we need this for #24279?

@heroxbd heroxbd self-requested a review March 20, 2022 05:25
@heroxbd heroxbd self-assigned this Mar 20, 2022
@littlewu2508
Copy link
Contributor Author

Do we need this for #24279?

llvm-roc-5.0 also need this. Let me add it into the 5.0 patch series

@heroxbd
Copy link
Contributor

heroxbd commented May 1, 2022

In tree by cb2eea1.

@heroxbd heroxbd closed this May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heroxbd heroxbd Awaiting requested review from heroxbd

Assignees

@heroxbd heroxbd

Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@littlewu2508 @gentoo-bot @gentoo-repo-qa-bot @heroxbd