go-module.eclass: invoke "ego mod tidy" with nonfatal #24437
Conversation
Flowdalic
force-pushed
the
go-module-eclass-nonfatal
branch
from
b19a587
to
da9943d
Compare
gentoo-bot
added
need assignment
Pull request CI reportReport generated at: 2022-03-07 09:02 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
We previously invoked "mod tidy" without the ego helper function in a non-fatal way. This was switched to using the ego helper in f9ee55e ("go-module.eclass: use ego helper function") but without prefixing the call with nonfatal. Hence the semantic of the eclass changes: a previously non-fatal invocation became fatal, causing e.g., bug #834695. Fixes: f9ee55e ("go-module.eclass: use ego helper function") Closes: https://bugs.gentoo.org/834758 Signed-off-by: Florian Schmaus <flow@gentoo.org>
Flowdalic
force-pushed
the
go-module-eclass-nonfatal
branch
from
da9943d
to
fc12d0d
Compare
Flowdalic
changed the title
gentoo-bot
changed the title
Pull Request assignmentSubmitter: @Flowdalic @gentoo/github Linked bugsBugs linked: 834758 New packagesThis Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
need assignment
Pull request CI reportReport generated at: 2022-03-08 08:37 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
We previously invoked "mod tidy" without the ego helper function in a
non-fatal way. This was switched to using the ego helper in
f9ee55e ("go-module.eclass: use ego helper function") but without
prefixing the call with nonfatal. Hence the semantic of the eclass
changes: a previously non-fatal invocation became fatal, causing e.g.,
bug #834695.
Fixes: f9ee55e ("go-module.eclass: use ego helper function")
Closes: https://bugs.gentoo.org/834695