x11-libs/vte version bump to 0.28.2-r208 #2444
Conversation
|
Gentto bug report: https://bugs.gentoo.org/show_bug.cgi?id=595770 |
|
monsieurp
added
version bump
assigned
|
Sorry that I was not clear. With converting to |
|
@doughdemon sorry I did quite understand what you ment before. My primary intention was to include patch for reported bug. I do not feel comfortable in changing anything else in this ebuild since I'm not an export in this area and changing without good understanding can have impact on package stability. So I will just revet python-single-r1 to python-r1 |
There was a problem hiding this comment.
What @doughdemon -- please switch it back to python-r1, or update for python-single-r1 completely. You're calling the functions from the wrong eclass right now, i.e. it can't work. Also, please squash this into a single commit, there is no reason to split it here.
- version bump - included patch for vte2 fixing bug described below - added call to epatch_user If you are using gnome-terminal or xfce4-terminal, you may have hit a bug in vte3. A fix is around since at least 2010, which found its way into some (but not all) distribution packages, and even into upstream (3 years later, but unchanged). Upstream bugzilla and other links - Original (?): https://bugzilla.gnome.org/show_bug.cgi?id=542087 - One of its duplicate: https://bugzilla.gnome.org/show_bug.cgi?id=686097 - reported mosh bug related to this problem: mobile-shell/mosh#660 - vte upstream commit: https://git.gnome.org/browse/vte/commit/?id=88e8e89560a62d0981ce2b18974a230d0a07dbdd - used backported patch for vte2: pld-linux/vte0@1e8dce1
|
@mgorny reverted to python-r1 and squashed |
|
You can also drop the DOCS specific statement with eapi6 and gnome2.eclass usage Additionally, if I don't misremember you need to also provide in the PR the updated Manifest for allowing us to directly push it... but maybe I am wrong as I am still not fully used to github workflow, sorry if that is the case |
| DOCS="AUTHORS ChangeLog HACKING NEWS README" | ||
|
|
||
| src_prepare() { | ||
|
|
There was a problem hiding this comment.
This empty line needs to be removed.
|
@gentoo/gnome, any more comments here? Should I fix the commit messages and the empty line and merge, or does one of you want to? |
|
If you have time to do, please go ahead And thanks a lot! |
@gentoo/gnome
Changes
Bug details
If you are using gnome-terminal or xfce4-terminal, you may have hit a bug in vte3.
A fix is around since at least 2010, which found its way into some
(but not all) distribution packages, and even into upstream (3 years later,
but unchanged).
Bugzilla and other links
https://bugzilla.gnome.org/show_bug.cgi?id=542087
https://bugzilla.gnome.org/show_bug.cgi?id=686097
vte based terminals & mosh mobile-shell/mosh#660
https://git.gnome.org/browse/vte/commit/?id=88e8e89560a62d0981ce2b18974a230d0a07dbdd
pld-linux/vte0@1e8dce1