net-misc/seafile{,-client}: version bump to 8.0.6 #24544
Conversation
Pull Request assignmentSubmitter: @CaseOf net-misc/seafile: @CaseOf, @gentoo/proxy-maint Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
Pull request CI reportReport generated at: 2022-03-14 00:06 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Thanks :) Some ideas for next time in the review.
I also filed a stabilisation bug. Maybe once version 8.0.5 is marked as stable, you could go and delete all of the old versions.
|
|
||
| DESCRIPTION="File syncing and sharing software with file encryption and group sharing" | ||
| HOMEPAGE="https://www.seafile.com/ https://github.com/haiwen/seafile/" | ||
| SRC_URI="https://github.com/haiwen/${PN}/archive/${RELEASE_COMMIT}.tar.gz -> ${P}.tar.gz" |
There was a problem hiding this comment.
To save a bit of manual work each update, you can use ${PV} here like this:
| SRC_URI="https://github.com/haiwen/${PN}/archive/${RELEASE_COMMIT}.tar.gz -> ${P}.tar.gz" | |
| SRC_URI="https://github.com/haiwen/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz" |
(S="..." will also need changing)
There was a problem hiding this comment.
Hi,
I was using commit hash since some versions ago because upstream was changing tags to other commit without warning.
Then I thought it was better to keep this behavior to avoid unnecessary issues.
There was a problem hiding this comment.
Yes, seconding this. I've seen this upstream moving tags around before, and not only once.
fwiw maybe a note in the ebuild be nice so other developers don't wonder why every time?
| # Copyright 1999-2022 Gentoo Authors | ||
| # Distributed under the terms of the GNU General Public License v2 | ||
|
|
||
| EAPI=7 |
There was a problem hiding this comment.
Maybe we could bump to EAPI-8 next time :)
| EAPI=7 | |
| EAPI=8 |
|
|
||
| DESCRIPTION="Seafile desktop client" | ||
| HOMEPAGE="https://www.seafile.com/ https://github.com/haiwen/seafile-client/" | ||
| SRC_URI="https://github.com/haiwen/${PN}/archive/${RELEASE_COMMIT}.tar.gz -> ${P}.tar.gz" |
There was a problem hiding this comment.
Same as above, since the upstream are still creating tags for each release, you can use ${PV} here.
Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Quentin Retornaz <gentoo@retornaz.com>
Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Quentin Retornaz <gentoo@retornaz.com>
Pull request CI reportReport generated at: 2022-03-31 23:04 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Sorry for the delay, I saw https://bugs.gentoo.org/685920 and wanted to make sure that it was okay to keep in ::gentoo :) |
No description provided.