net-misc/tigervnc: Fix the init script #24703
Conversation
Remove $VNC_OPTS from conf.d Make init script POSIX compliant Closes: https://bugs.gentoo.org/835730 Closes: https://bugs.gentoo.org/506522 Signed-off-by: Viorel Munteanu <ceamac.paragon@gmail.com>
Pull Request assignmentSubmitter: @ceamac net-misc/tigervnc: @gentoo/proxy-maint (maintainer needed) Linked bugsIn order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
maintainer-needed
Pull request CI reportReport generated at: 2022-03-22 07:46 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| sessionpid=$(cat /run/vncsession-:"${user##*:}".pid) | ||
| serverpid=$(pstree -p "$sessionpid" | grep Xvnc | sed -e 's/^.*Xvnc(// | ||
| s/).*$//') | ||
| kill "$serverpid" >/dev/null 2>&1 |
There was a problem hiding this comment.
I guess sessionpid and serverpid should never contain whitespace or special characters. Thus, the quotations marks seem to be superfluous to me.
There was a problem hiding this comment.
Yes, I added them only to silence shellcheck. They don't do any harm anyway.
There was a problem hiding this comment.
Overquoting is generally better than underquoting, yep.
The ebuild is unchanged, only a revbump. The changes are in
files/Remove $VNC_OPTS from conf.d and add a message instead
Since I had to change the init script, I also ran
checkbashismsandshellcheckon it.I only fixed
tigervnc-1.12, 1.9 is untouched.