Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-process/cronie: fix cronie pidfile path #24716

Closed
wants to merge 1 commit into from

Conversation

thesamesam
Copy link
Member

cronie's build system is using runstatedir to determine
where to place the PID file. On one of my systems,
this path happens to exist because of thermald,
but it won't usually exist.

We should set runstatedir to be "${EPREFIX}"/run
to store the PID file in the place the init script expects
(cronie hardcodes the value of runstatedir into the binary
to find where its pidfile is).

Closes: https://bugs.gentoo.org/835814
Bug: https://bugs.gentoo.org/685306
Signed-off-by: Sam James sam@gentoo.org

cronie's build system is using runstatedir to determine
where to place the PID file. On one of my systems,
this path _happens_ to exist because of thermald,
but it won't usually exist.

We should set runstatedir to be "${EPREFIX}"/run
to store the PID file in the place the init script expects
(cronie hardcodes the value of runstatedir into the binary
to find where its pidfile is).

Closes: https://bugs.gentoo.org/835814
Bug: https://bugs.gentoo.org/685306
Signed-off-by: Sam James <sam@gentoo.org>
@thesamesam
Copy link
Member Author

@Polynomial-C

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @thesamesam
Areas affected: ebuilds
Packages affected: sys-process/cronie

sys-process/cronie: polynomial-c

At least one of the listed packages is maintained entirely by non-GitHub developers!

Linked bugs

Bugs linked: 685306, 835814


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 22, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-03-22 22:51 UTC
Newest commit scanned: 0fdf2b8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5fc9d19bd4/output.html

@thesamesam
Copy link
Member Author

Fixed in https://bugs.gentoo.org/685306#c1 and followup to add the ${EPREFIX}.

@thesamesam thesamesam closed this Mar 27, 2022
@thesamesam thesamesam deleted the cronie-pidpath branch March 27, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug linked Bug/Closes found in footer, and cross-linked with the PR. need assignment It was impossible to assign the PR correctly. Please assign it manually.
Projects
None yet
3 participants