Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x11-plugins/gkwebmon: update EAPI 6 -> 8 #24724

Closed
wants to merge 1 commit into from

Conversation

laumann
Copy link
Contributor

@laumann laumann commented Mar 23, 2022

Changes:

  • { -> B}DEPEND="virtual/pkgconfig". The dependency is also provided by the eclass, but asking on #gentoo-dev it was recommended to keep it, because the ebuild explicitly does tc-export PKG_CONFIG.

Signed-off-by: Thomas Bracht Laumann Jespersen t@laumann.xyz

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @laumann
Areas affected: ebuilds
Packages affected: x11-plugins/gkwebmon

x11-plugins/gkwebmon: @gentoo/proxy-maint (maintainer needed)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Mar 23, 2022
@laumann
Copy link
Contributor Author

laumann commented Mar 23, 2022

@thesamesam Another one.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-03-23 08:51 UTC
Newest commit scanned: d67d3f6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6e606eccad/output.html

@thesamesam
Copy link
Member

Oh, while we're at it: you are welcome to (but it's not required) to do all of these in one PR to allow easier review and stuff.

@laumann
Copy link
Contributor Author

laumann commented Mar 24, 2022

Oh, while we're at it: you are welcome to (but it's not required) to do all of these in one PR to allow easier review and stuff.

I did consider it :-) I can one big PR with a commit per ebuild.

Signed-off-by: Thomas Bracht Laumann Jespersen <t@laumann.xyz>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-03-24 08:53 UTC
Newest commit scanned: bb6971e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/97f4dd8f92/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this waiting for some eclass EAPI update? Seems to work fine at least already.

 * VDB: detected possibly incorrect RDEPEND (x11-plugins/gkwebmon-0.2-r3)
 *                  > dev-libs/glib:2
 *                  > x11-libs/gtk+:2
 * dev-libs/openssl < 

Could you check these?

@laumann
Copy link
Contributor Author

laumann commented Mar 31, 2022

Was this waiting for some eclass EAPI update?

No, the eclass was already updated in 5b1df6b

Seems to work fine at least already.

 * VDB: detected possibly incorrect RDEPEND (x11-plugins/gkwebmon-0.2-r3)
 *                  > dev-libs/glib:2
 *                  > x11-libs/gtk+:2
 * dev-libs/openssl < 

Could you check these?

Happily, but I'm not sure what I need to check here.

And now you made me curious :-) How did you get this report?

@laumann laumann deleted the eapi8/x11-plugins/gkwebmon branch March 31, 2022 13:07
@juippis
Copy link
Member

juippis commented Mar 31, 2022

I ended up merging this PR and doing a followup commit, c877f78. It's from iwdevtools, https://packages.gentoo.org/packages/app-portage/iwdevtools

We don't depend on indirect deps. In theory, if gkgrellm dropped glib in a future release, it'd break gkwebmon. So always list exactly the needed deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits.
Projects
None yet
5 participants