sys-libs/liburing: pass --cxx parameter to configure #24733
Closed
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentoo-bot
added
need assignment
jepio
force-pushed
the
liburing-fix-x-compile
branch
from
7dde715
to
17010b2
Compare
Pull request CI reportReport generated at: 2022-03-24 11:36 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2022-03-24 12:06 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Provide the correct value to --cxx to fix cross-compilation. liburing uses the value of the cxx variable for linking. This happens to work for native builds but breaks when cross-compiling, as evidenced by the below output (from Flatcar): >>> Configuring source in /build/arm64-usr/var/tmp/portage/sys-libs/liburing-2.1-r1/work/liburing-2.1 ... * .arm64: running multilib-minimal_abi_src_configure prefix /usr includedir /usr/include libdir /usr/lib64 libdevdir /usr/lib64 relativelibdir mandir /usr/share/man datadir /usr/share stringop_overflow yes array_bounds yes __kernel_rwf_t yes __kernel_timespec yes open_how no statx yes C++ yes has_ucontext yes CC aarch64-cros-linux-gnu-gcc CXX g++ ... aarch64-cros-linux-gnu-gcc -D_GNU_SOURCE -D__SANE_USERSPACE_TYPES__ -I../src/include/ -include ../config-host.h -O2 -pipe -mtune=generic -g -D_GNU_SOURCE -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -L../src/ -o statx statx.c helpers.o -luring -Wstringop-overflow=0 -Warray-bounds=0 g++ -D_GNU_SOURCE -D__SANE_USERSPACE_TYPES__ -I../src/include/ -include ../config-host.h -O2 -pipe -mtune=generic -g -O2 -pipe -mtune=generic -g -D_GNU_SOURCE -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -L../src/ -std=c++11 -o sq-full-cpp sq-full-cpp.cc helpers.o -luring -Wstringop-overflow=0 -Warray-bounds=0 /usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183) /usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183) /usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183) /usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183) /usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183) /usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183) /usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: error adding symbols: file in wrong format collect2: error: ld returned 1 exit status make[1]: *** [Makefile:165: sq-full-cpp] Error 1 make[1]: *** Waiting for unfinished jobs.... Bug: https://bugs.gentoo.org/836316 Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio
force-pushed
the
liburing-fix-x-compile
branch
from
17010b2
to
0118735
Compare
jepio
changed the title
gentoo-bot
changed the title
Pull Request assignmentSubmitter: @jepio sys-libs/liburing: At least one of the listed packages is maintained entirely by non-GitHub developers! Linked bugsBugs linked: 836316 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
need assignment
Pull request CI reportReport generated at: 2022-03-28 09:18 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
jepio
changed the title
t-lo
added a commit
to flatcar-archive/portage-stable
that referenced
this pull request
Jun 10, 2022
This change adds ARM64 support for
dev-libs/ding-libs
sec-policy/selinux-sssd
sys-libs/liburing
by un-masking ARM64 architecture.
Also, it bumps liburing-2.1 to upstream -rc2 and ingests a cross
compiler fix (gentoo/gentoo#24733).
Signed-off-by: Thilo Fromm <thilo@kinvolk.io>
t-lo
added a commit
to flatcar-archive/portage-stable
that referenced
this pull request
Jun 10, 2022
This change bumps liburing-2.1 to upstream -rc2 and ingests a cross compiler fix (gentoo/gentoo#24733). Also, it removes the mask for ARM64 in sec-policy/selinux-sssd to match Gentoo upstream. Signed-off-by: Thilo Fromm <thilo@kinvolk.io>
t-lo
added a commit
to flatcar-archive/portage-stable
that referenced
this pull request
Jun 15, 2022
This change bumps liburing-2.1 to upstream -rc2 and ingests a cross compiler fix (gentoo/gentoo#24733). Also, it removes the mask for ARM64 in sec-policy/selinux-sssd to match Gentoo upstream. Signed-off-by: Thilo Fromm <thilo@kinvolk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to fix cross-compilation of liburing, as cxx (default g++) is used for linking applications that are built.
Bug: https://bugs.gentoo.org/836316