-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
media-libs/libjxl: version bump to 20220329 snapshot #24807
Conversation
Pull Request assignmentSubmitter: @novomesk media-libs/libjxl: @novomesk, @gentoo/proxy-maint Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2022-03-29 19:32 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
x11-misc/shared-mime-info | ||
openexr? ( media-libs/openexr:= ) | ||
" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop extra newline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are referring to the place after openexr dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a blank line between the "
and the RDEPEND
assignment. (I like the "
on its own line)
mycmakeargs+=( | ||
-DJPEGXL_ENABLE_TOOLS=ON | ||
-DJPEGXL_ENABLE_EXAMPLES=$(usex examples) | ||
-DJPEGXL_ENABLE_OPENEXR=$(usex openexr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can use multilib_native_usex
here and pull it out of the if statement.
|
Pull request CI reportReport generated at: 2022-04-01 08:22 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2022-04-02 06:07 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Daniel Novomesky <dnovomesky@gmail.com>
Pull request CI reportReport generated at: 2022-04-02 19:22 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
@dlan17 Please test if it works for you.