Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-libs/libjxl: version bump to 20220329 snapshot #24807

Closed
wants to merge 1 commit into from
Closed

media-libs/libjxl: version bump to 20220329 snapshot #24807

wants to merge 1 commit into from

Conversation

novomesk
Copy link
Contributor

@dlan17 Please test if it works for you.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @novomesk
Areas affected: ebuilds
Packages affected: media-libs/libjxl

media-libs/libjxl: @novomesk, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Mar 29, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-03-29 19:32 UTC
Newest commit scanned: cf4f7f6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/045ad7a976/output.html

x11-misc/shared-mime-info
openexr? ( media-libs/openexr:= )
"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop extra newline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are referring to the place after openexr dependency?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a blank line between the " and the RDEPEND assignment. (I like the " on its own line)

mycmakeargs+=(
-DJPEGXL_ENABLE_TOOLS=ON
-DJPEGXL_ENABLE_EXAMPLES=$(usex examples)
-DJPEGXL_ENABLE_OPENEXR=$(usex openexr)
Copy link
Contributor

@mattst88 mattst88 Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use multilib_native_usex here and pull it out of the if statement.

@novomesk novomesk marked this pull request as draft April 1, 2022 05:42
@novomesk
Copy link
Contributor Author

novomesk commented Apr 1, 2022

image/jxl mime-type is now present in shared-mime-info-2.2 so we no longer need to install it via libjxl. I modified also live ebuild accordingly.

@novomesk novomesk marked this pull request as ready for review April 1, 2022 08:02
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-04-01 08:22 UTC
Newest commit scanned: 52ec354
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4649480ecd/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-04-02 06:07 UTC
Newest commit scanned: 76f7c6a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a1e10f4599/output.html

Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Daniel Novomesky <dnovomesky@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-04-02 19:22 UTC
Newest commit scanned: 0997e4f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/423bed5ab3/output.html

@gentoo-bot gentoo-bot closed this in 83eb9eb Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants