Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-libs/ncurses: Remove libcurses.so symlink #24882

Closed
wants to merge 1 commit into from
Closed

sys-libs/ncurses: Remove libcurses.so symlink #24882

wants to merge 1 commit into from

Conversation

mgorny
Copy link
Member

@mgorny mgorny commented Apr 3, 2022

Closes: https://bugs.gentoo.org/836696
Signed-off-by: Michał Górny mgorny@gentoo.org

@mgorny mgorny added the noci Skip CI for this pull request label Apr 3, 2022
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mgorny
Areas affected: ebuilds
Packages affected: sys-libs/ncurses

sys-libs/ncurses: @gentoo/base-system

Linked bugs

Bugs linked: 836696

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 3, 2022
@floppym
Copy link
Contributor

floppym commented Apr 4, 2022

It looks like it might be "cleaner" to disable this via the build system by passing --disable-overwrite to configure.

@mgorny
Copy link
Member Author

mgorny commented Apr 4, 2022

It looks like it might be "cleaner" to disable this via the build system by passing --disable-overwrite to configure.

This causes "baseline" headers to be moved into ncurses subdirectory. Is that desirable?

@floppym
Copy link
Contributor

floppym commented Apr 4, 2022

This causes "baseline" headers to be moved into ncurses subdirectory. Is that desirable?

Yeah, I realized that after looking at it further. I think this will probably cause some additional build-time failures for packages that don't use pkg-config properly, but fixing these might be better in the long run.

@floppym
Copy link
Contributor

floppym commented Apr 4, 2022

Let's stick with just removing the libcurses symlinks for now, and tackle the headers relocation separately, at a later date.

@mgorny
sys-libs/ncurses: Remove libcurses.so symlink
8cfa353 
Closes: https://bugs.gentoo.org/836696
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@gentoo-bot gentoo-bot closed this in 1117e61 Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Polynomial-C Polynomial-C Polynomial-C left review comments

@thesamesam thesamesam thesamesam left review comments

@floppym floppym floppym approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. noci Skip CI for this pull request
Projects
None yet
Milestone
No milestone
5 participants
@mgorny @gentoo-bot @floppym @Polynomial-C @thesamesam