Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-apps/ccs-tools: EAPI8, minor fixes #24919

Closed
wants to merge 1 commit into from
Closed

sys-apps/ccs-tools: EAPI8, minor fixes #24919

wants to merge 1 commit into from

Conversation

mm1ke
Copy link
Contributor

@mm1ke mm1ke commented Apr 5, 2022

Hi,

This updates sys-apps/ccs-tools to EAPI8 and fixes some minor issues. The QA warning about the compressed man pages was fixed by decompressing them in src_prepare - hope that's fine.

Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Michael Mair-Keimberger mmk@levelnine.at
Closes: https://bugs.gentoo.org/732040

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mm1ke
Areas affected: ebuilds
Packages affected: sys-apps/ccs-tools

sys-apps/ccs-tools: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 732040

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 5, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-04-05 18:57 UTC
Newest commit scanned: 4385df8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ee8bf4ad35/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-04-05 19:27 UTC
Newest commit scanned: 527c270
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c9e9eaf17e/output.html

ConiKost
ConiKost reviewed Apr 6, 2022
View reviewed changes
sys-apps/ccs-tools/ccs-tools-1.8.3_p20130214.ebuild Outdated
DEPEND="${CDEPEND}
virtual/pkgconfig"
DEPEND="${CDEPEND}"
BDEPEND="virtual/pkgconfig"

S="${WORKDIR}/${PN}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S after SRC_URI please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, fixed now :)

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-04-07 05:12 UTC
Newest commit scanned: 06eb8d7
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/731aded140/output.html

ConiKost
ConiKost reviewed Apr 7, 2022
View reviewed changes
sys-apps/ccs-tools/ccs-tools-1.8.3_p20130214.ebuild Outdated

LICENSE="GPL-2"
SLOT="0"
KEYWORDS="~amd64 ~x86"
IUSE=""
RESTRICT="test"

CDEPEND="
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are at it, could you rename to COMMON_DEPEND? Just in case, if we ever should introduce some official CDEPEND. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, no problem :)

@mm1ke
sys-apps/ccs-tools: EAPI8, minor fixes
9d89305 
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Michael Mair-Keimberger <mmk@levelnine.at>
Closes: https://bugs.gentoo.org/732040
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-04-07 16:32 UTC
Newest commit scanned: 9d89305
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/aa3711a3f6/output.html

@gentoo-bot gentoo-bot closed this in f3a1d9a Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConiKost ConiKost ConiKost approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
4 participants
@mm1ke @gentoo-bot @gentoo-repo-qa-bot @ConiKost