vim-{doc,plugin}.eclass: support EAPI 8 #24928
Conversation
Pull Request assignmentSubmitter: @laumann @gentoo/github Linked bugsNew packagesThis Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
need assignment
|
cc @monsieurp Should there be an inherit guard in vim-plugin.eclass, like vim-doc.eclass? |
|
Also, I know I'm supposed to send patches to gentoo-dev ML - was thinking I'd do that after adding changes here. |
Pull request CI reportReport generated at: 2022-04-06 07:47 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
laumann
force-pushed
the
eapi8/vim-plugin.eclass
branch
2 times, most recently
from
b1b7726
to
0e07753
Compare
Pull request CI reportReport generated at: 2022-04-06 08:12 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2022-04-06 08:42 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Let's wait until those patches are reviewed on the gentoo-dev ML. |
Signed-off-by: Thomas Bracht Laumann Jespersen <t@laumann.xyz>
* Drop EAPI 0, 1, 2 workarounds * Move EXPORT_FUNCTIONS to end of file * Add required @Usage on functions Bug: https://bugs.gentoo.org/830867 Bug: https://bugs.gentoo.org/830866 Signed-off-by: Thomas Bracht Laumann Jespersen <t@laumann.xyz>
laumann
force-pushed
the
eapi8/vim-plugin.eclass
branch
from
0e07753
to
bdfefd1
Compare
Pull request CI reportReport generated at: 2022-04-06 12:02 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
I made some comments a while ago that @monsieurp was going to circle back to. Could you ensure they're addressed in this set? https://marc.info/?l=gentoo-dev&m=162692547126278&w=2 (At a skim, I think they are.) |
|
Closing this in favor of #24941. |
vim-doc.eclass
$varwith${var}vim-plugin.eclass
@USAGE:on functionsBug: https://bugs.gentoo.org/830867
Bug: https://bugs.gentoo.org/830866