Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-im/telegram-desktop: Fix building with KWayland 5.93 #24998

Closed
wants to merge 4 commits into from
Closed

net-im/telegram-desktop: Fix building with KWayland 5.93 #24998

wants to merge 4 commits into from

Conversation

mid-kid
Copy link
Contributor

@mid-kid mid-kid commented Apr 11, 2022

@gyakovlev

Not revbumping since this doesn't affect runtime, only rebuilds.

@mid-kid
net-im/telegram-desktop: Drop old
bc48308 
Signed-off-by: Esteve Varela Colominas <esteve.varela@gmail.com>
@mid-kid
media-libs/tg_owt: Drop old
1b9ad6f 
Signed-off-by: Esteve Varela Colominas <esteve.varela@gmail.com>
@mid-kid
media-libs/libtgvoip: Drop old
7ca591c 
Signed-off-by: Esteve Varela Colominas <esteve.varela@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mid-kid
Areas affected: ebuilds
Packages affected: media-libs/libtgvoip, media-libs/tg_owt, net-im/telegram-desktop

media-libs/libtgvoip: @mid-kid, @gentoo/proxy-maint
media-libs/tg_owt: @mid-kid, @gentoo/proxy-maint
net-im/telegram-desktop: @mid-kid, @gentoo/proxy-maint

Linked bugs

Bugs linked: 837569

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 11, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-04-11 23:02 UTC
Newest commit scanned: 60b31b4
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f3c5631b23/output.html

@mid-kid
net-im/telegram-desktop: Fix building with KWayland 5.93
2ca3059 
Closes: https://bugs.gentoo.org/837569
Thanks-to: Nick Sarnie <sarnex@gentoo.org>
Signed-off-by: Esteve Varela Colominas <esteve.varela@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-04-12 05:52 UTC
Newest commit scanned: 2ca3059
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/58463bd71b/output.html

@mid-kid
Copy link
Contributor Author

mid-kid commented Apr 14, 2022 •
edited
Loading

@thesamesam @gyakovlev requesting re-review and merge since this solves a fairly common build error. (I've never had this many CCs in a bug report)

thesamesam
thesamesam reviewed Apr 15, 2022
View reviewed changes
net-im/telegram-desktop/files/tdesktop-3.6.1-fix-kwayland-5.93.patch
@@ -0,0 +1,55 @@
Fix compatibility with kwayland-5.93.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with < 5.93.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@mid-kid mid-kid deleted the telegram branch April 24, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam thesamesam left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@mid-kid @gentoo-bot @gentoo-repo-qa-bot @thesamesam