sys-libs/gdbm: call elibtoolize in src_prepare #25219
Conversation
Pull Request assignmentSubmitter: @m-gupta sys-libs/gdbm: @gentoo/base-system Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. Missing GCO sign-offPlease read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
|
fwiw, elibtoolize used to be called in older versions: https://gitweb.gentoo.org/repo/gentoo.git/commit/sys-libs/gdbm?id=44af412c0086421e18075a413dc2aba43dae6d8c. It was replaced by a bigger hammer |
| @@ -20,6 +20,11 @@ DEPEND="readline? ( sys-libs/readline:=[${MULTILIB_USEDEP}] )" | |||
| RDEPEND="${DEPEND}" | |||
| BDEPEND="verify-sig? ( sec-keys/openpgp-keys-gdbm )" | |||
|
|
|||
| src_prepare() { | |||
| default | |||
| elibtoolize | |||
There was a problem hiding this comment.
Let's add a comment explaing why to avoid this happening in future.
Do wonder if it's stale in the tarball or if the fix never actually landed in upstream libtool so we need our patches for it.
There was a problem hiding this comment.
Ah, checking build-aux/ltmain.sh:
#! /bin/sh
## DO NOT EDIT - This file generated from ./build-aux/ltmain.in
## by inline-source v2014-01-03.01
# libtool (GNU libtool) 2.4.6
# Provide generalized library-building support services.
# Written by Gordon Matzigkeit <gord@gnu.ai.mit.edu>, 1996
# Copyright (C) 1996-2015 Free Software Foundation, Inc.
# This is free software; see the source for copying conditions. There is NO
# warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
[...]
so yeah, their distro hasn't got 2.4.7 yet, and even that may not have the needed patches.
Pull request CI reportReport generated at: 2022-04-26 22:42 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
gdbm's default libtool file causes to link with /usr/lib directory i.e. -L/usr/lib which causes linker (LLD) to complain when cross-compiling building for arm32. Call elibtoolize in src_prepare to regen files to avoid the linker errors. Signed-off-by: Manoj Gupta <manojgupta@google.com>
|
Updated with a comment about old libtool files. |
Pull request CI reportReport generated at: 2022-04-26 23:27 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Thanks! |
|
(FWIW: Fixed in 54f604a.) |
|
oops, thanks for fixing. |
gdbm's default libtool file causes to link with /usr/lib directory
i.e. -L/usr/lib which causes linker (LLD) to complain when
cross-compiling building for arm32.
Call elibtoolize in src_prepare to regen files to avoid the
linker errors.