Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiprocessing.eclass: change default inf to nproc + distutils-r1 pbr build system #25238

Closed
wants to merge 13 commits into from

Conversation

mgorny
Copy link
Member

@mgorny mgorny commented Apr 28, 2022

CC @gentoo/qa

From the relevant commit:

Change the default value for 'inf' argument to makeopts_jobs from 999
to $(get_nproc). This means that if MAKEOPTS specifies a -j argument
without a specific value, nproc will be used rather than infinity-ish
number of jobs.

The old default made sense for ebuilds using both makeopts_jobs
and makeopts_loadavg. However, these are very rare — only 4 packages
and 3 eclass at this time. For the remaining ebuilds, they meant
uncontrollably using up to 999 jobs.

The new default is both safer and more correct for the vast majority
of Gentoo packages, removing the necessity of repeating:

$(makeopts_jobs "${MAKEOPTS}" "$(get_nproc)")

The ebuilds and eclasses using makeopts_loadavg have been updated
to pass the old default.

Also includes tiny distutils-r1 change to avoid updating the cache twice.

@mgorny mgorny added the no assignee limit Ignore assignee limit, and ping as many maintainers as it takes. label Apr 28, 2022
@mgorny
Copy link
Member Author

mgorny commented Apr 28, 2022

CC @gentoo/kde for cmake*, @floppym for ninja-utils

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mgorny
Areas affected: ebuilds, eclasses
Packages affected: app-i18n/mozc, dev-python/fixtures, dev-qt/qtwebengine, dev-util/cmake, media-sound/apulse

app-i18n/mozc: @Arfrever, @gentoo/cjk
dev-python/fixtures: @prometheanfire, @gentoo/python
dev-qt/qtwebengine: @gentoo/qt, @gyakovlev
dev-util/cmake: @gentoo/base-system, @gentoo/kde
media-sound/apulse: @bircoph

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Apr 28, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-04-28 11:23 UTC
Newest commit scanned: 9a72dbc
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/672f8b0566/output.html

Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Change the default value for 'inf' argument to makeopts_jobs from 999
to $(get_nproc) + 1.  This means that if MAKEOPTS specifies a `-j`
argument without a specific value, nproc will be used rather than
infinity-ish number of jobs.

The old default made sense for ebuilds using both makeopts_jobs
and makeopts_loadavg.  However, these are very rare — only 4 packages
and 3 eclass at this time.  For the remaining ebuilds, they meant
uncontrollably using up to 999 jobs.

The new default is both safer and more correct for the vast majority
of Gentoo packages, removing the necessity of repeating:

    $(makeopts_jobs "${MAKEOPTS}" "$(get_nproc)")

The ebuilds and eclasses using makeopts_loadavg have been updated
to pass the old default.

Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-04-28 13:53 UTC
Newest commit scanned: fac121c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2a5ac41a1d/output.html

@gentoo-bot gentoo-bot closed this in 625ad1f May 1, 2022
@mgorny mgorny deleted the distutils-changes branch February 21, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no assignee limit Ignore assignee limit, and ping as many maintainers as it takes. no bug found No Bug/Closes found in the commits.
Projects
None yet
3 participants