Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pecl-memcached: bump to 3.2.0 with new memcached library #25253

Closed
wants to merge 2 commits into from
Closed

pecl-memcached: bump to 3.2.0 with new memcached library #25253

wants to merge 2 commits into from

Conversation

hydrapolic
Copy link
Contributor

@hydrapolic hydrapolic commented Apr 29, 2022 •
edited

Tests pass on ~amd64.

--- pecl-memcached-3.2.0.ebuild 2022-05-16 16:38:42.409036198 +0000
+++ pecl-memcached-3.2.0-r1.ebuild      2022-05-16 16:40:05.026417238 +0000
@@ -21,7 +21,7 @@
 
 RESTRICT="!test? ( test )"
 
-COMMON_DEPEND=">=dev-libs/libmemcached-1.0.14[sasl(-)?]
+COMMON_DEPEND="|| ( dev-libs/libmemcached-awesome[sasl(-)?] >=dev-libs/libmemcached-1.0.14[sasl(-)?] )
        sys-libs/zlib
        igbinary? ( dev-php/igbinary[php_targets_php7-4(-)?,php_targets_php8-0(-)?,php_targets_php8-1(-)?] )
 "

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @hydrapolic
Areas affected: ebuilds
Packages affected: dev-libs/libmemcached-awesome, dev-php/pecl-memcached

dev-libs/libmemcached-awesome: @gentoo/proxy-maint (new package)
dev-php/pecl-memcached: @robbat2, @gentoo/php

Linked bugs

Bugs linked: 841608, 841605

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 29, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-04-29 11:47 UTC
Newest commit scanned: eafda60
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d25e8badaf/output.html

@thesamesam
Copy link
Member

If memcached-awesome is preferred, we should put it first in || ( ... ). Could you rebase?

@hydrapolic
Copy link
Contributor Author

If memcached-awesome is preferred, we should put it first in || ( ... ). Could you rebase?

I put it secondary since it's a new package, but I've no problem with reversing the order. Will do.

@hydrapolic
dev-libs/libmemcached-awesome: new package
cdcd7ef 
libmemcache 1.0.18 was released in February 2014, so hasn't received an
update for 8 years.

libmemcache-awesome is a fork providing same libraries, tools with
API/ABI compatibility.

Closes: https://bugs.gentoo.org/841605
Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
@hydrapolic
dev-php/pecl-memcached: prefer dev-libs/libmemcached-awesome
b4c81ec 
Closes: https://bugs.gentoo.org/841608
Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
@hydrapolic
Copy link
Contributor Author

@thesamesam it's ready.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-16 17:01 UTC
Newest commit scanned: b4c81ec
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/67a03c92c9/output.html

@thesamesam thesamesam self-requested a review May 16, 2022 21:07
@hydrapolic
Copy link
Contributor Author

Thank you @thesamesam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam Awaiting requested review from thesamesam

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package.
Projects
None yet
Milestone
No milestone
4 participants
@hydrapolic @gentoo-bot @gentoo-repo-qa-bot @thesamesam