Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-video/pipewire: Drop alsa-plugins[pulseaudio] blocker #25269

Conversation

i-garrison
Copy link
Contributor

@i-garrison i-garrison commented Apr 30, 2022

Currently alsa-plugins[pulseaudio] installs pulse plugin which is only enabled
in alsa lib configuration if plugin can access pulseaudio server in runtime.
This is implemented using a runtime conf hook in 51-pulseaudio-probe.conf

Alsa lib runtime conf hooks are run after all static configuration is applied.
This causes a problem to coexistence of pipewire-alsa and pulse plugin:

  • normally, pipewire-pulse is enabled which provides pulseaudio server
    connection to libpulse users
  • since pulseaudio server is accessible, pulse conf hook will override alsa
    pcm.!default and ctl.!default to use pulse plugin.

To work around this, change pipewire-alsa plugin configuration from static conf
to conf hook which will run after pulse conf hook. To make sure user can still
override default device, make sure this new conf hook will also load
/etc/asound.conf and ~/.asoundrc again like it is done by pulse conf hook.

Since pipewire plugin will take precedence now if pipewire-alsa is installed,
drop the blocker with media-sound/alsa-plugins[pulseaudio]

Closes: https://bugs.gentoo.org/799881
Closes: https://bugs.gentoo.org/791499
Signed-off-by: Igor V. Kovalenko igor.v.kovalenko@gmail.com

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @i-garrison
Areas affected: ebuilds
Packages affected: media-video/pipewire

media-video/pipewire: @gentoo/gnome, @thesamesam, @a17r, @Whissi

Linked bugs

Bugs linked: 799881, 791499


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 30, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-04-30 16:05 UTC
Newest commit scanned: 1d003c9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0c52b7c914/output.html

Copy link
Contributor

@pinkflames pinkflames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I'm testing this now and it seems to be working as intended. Thanks, Igor.

Currently alsa-plugins[pulseaudio] installs pulse plugin which is only enabled
in alsa lib configuration if plugin can access pulseaudio server in runtime.
This is implemented using a runtime conf hook in 51-pulseaudio-probe.conf

Alsa lib runtime conf hooks are run after all static configuration is applied.
This causes a problem to coexistence of pipewire-alsa and pulse plugin:
- normally, pipewire-pulse is enabled which provides pulseaudio server
  connection to libpulse users
- since pulseaudio server is accessible, pulse conf hook will override alsa
  pcm.!default and ctl.!default to use pulse plugin.

To work around this, change pipewire-alsa plugin configuration from static conf
to conf hook which will run after pulse conf hook. To make sure user can still
override default device, make sure this new conf hook will also load
/etc/asound.conf and ~/.asoundrc again like it is done by pulse conf hook.

Since pipewire plugin will take precedence now if pipewire-alsa is installed,
drop the blocker with media-sound/alsa-plugins[pulseaudio]

Closes: https://bugs.gentoo.org/799881
Closes: https://bugs.gentoo.org/791499
Signed-off-by: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
@i-garrison i-garrison force-pushed the pr/pipewire-alsa-coexistence-with-pulse-plugin branch from 1d003c9 to 81ce35c Compare April 30, 2022 16:20
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-04-30 16:35 UTC
Newest commit scanned: 81ce35c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/17524c00e9/output.html

@gentoo-bot gentoo-bot closed this in 431a2f1 May 1, 2022
@i-garrison i-garrison deleted the pr/pipewire-alsa-coexistence-with-pulse-plugin branch May 1, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants