Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-devel/llvm-roc: enbable openmp component #25318

Closed
wants to merge 1 commit into from

Conversation

littlewu2508
Copy link
Contributor

sci-libs/rocSPARSE fails tests if openmp is not enabled in llvm-roc

Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Yiyang Wu xgreenlandforwyy@gmail.com

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @littlewu2508
Areas affected: ebuilds
Packages affected: sys-devel/llvm-roc

sys-devel/llvm-roc: @candrews

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels May 4, 2022
sci-libs/rocSPARSE fails tests if openmp is not enabled in llvm-roc.
Correct usex to use in src_configure.

Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-04 10:40 UTC
Newest commit scanned: 94f15eb
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ae56576464/output.html

@heroxbd
Copy link
Contributor

heroxbd commented May 4, 2022

With clang-13 in the system it fails with:

-- LIBOMPTARGET: Building AMDGPU plugin linked against libhsa
-- LIBOMPTARGET: Not generating amdgcn test targets as amdgpu-arch is not found
-- LIBOMPTARGET: Building CUDA offloading plugin.
-- LIBOMPTARGET: Building CUDA plugin for dlopened libcuda
-- LIBOMPTARGET: Disabling tests using CUDA plugin as cuda may not be available
-- LIBOMPTARGET: Not building PPC64 offloading plugin: machine not found in the system.
-- LIBOMPTARGET: Not building PPC64le offloading plugin: machine not found in the system.
-- LIBOMPTARGET: Not building nec-aurora plugin: libveo or libveosinfo not found.
-- LIBOMPTARGET: Building x86_64 offloading plugin.
-- LIBOMPTARGET: Not building AMDGCN device RTL: AOMP not found
-- LIBOMPTARGET: Not building NVPTX deviceRTL by default on CUDA free system.
   -- Found AMDDeviceLibs config at /usr/lib/cmake/AMDDeviceLibs
   -- Building libm libdevice with LLVM 14.0.0roc found at /usr/lib/llvm/roc
   -- Building default set of AMD GPUs: gfx700;gfx701;gfx801;gfx803;gfx900
   -- You may override default with GFXLIST environment variable 
------------------- DIR: /var/tmp/portage/sys-devel/llvm-roc-5.0.2-r1/work/llvm-project-rocm-5.0.2/llvm_build/projects/openmp/libomptarget/deviceRTLs/libm/../../../runtime/src
------------------- DIR: /var/tmp/portage/sys-devel/llvm-roc-5.0.2-r1/work/llvm-project-rocm-5.0.2/llvm_build/projects/openmp/libomptarget/deviceRTLs/libm/../../../runtime/src
------------------- DIR: /var/tmp/portage/sys-devel/llvm-roc-5.0.2-r1/work/llvm-project-rocm-5.0.2/llvm_build/projects/openmp/libomptarget/deviceRTLs/libm/../../../runtime/src
------------------- DIR: /var/tmp/portage/sys-devel/llvm-roc-5.0.2-r1/work/llvm-project-rocm-5.0.2/llvm_build/projects/openmp/libomptarget/deviceRTLs/libm/../../../runtime/src
------------------- DIR: /var/tmp/portage/sys-devel/llvm-roc-5.0.2-r1/work/llvm-project-rocm-5.0.2/llvm_build/projects/openmp/libomptarget/deviceRTLs/libm/../../../runtime/src
------------------- DIR: /var/tmp/portage/sys-devel/llvm-roc-5.0.2-r1/work/llvm-project-rocm-5.0.2/llvm_build/projects/openmp/libomptarget/deviceRTLs/libm/../../../runtime/src
------------------- DIR: /var/tmp/portage/sys-devel/llvm-roc-5.0.2-r1/work/llvm-project-rocm-5.0.2/llvm_build/projects/openmp/libomptarget/deviceRTLs/libm/../../../runtime/src
------------------- DIR: /var/tmp/portage/sys-devel/llvm-roc-5.0.2-r1/work/llvm-project-rocm-5.0.2/llvm_build/projects/openmp/libomptarget/deviceRTLs/libm/../../../runtime/src
------------------- DIR: /var/tmp/portage/sys-devel/llvm-roc-5.0.2-r1/work/llvm-project-rocm-5.0.2/llvm_build/projects/openmp/libomptarget/deviceRTLs/libm/../../../runtime/src
------------------- DIR: /var/tmp/portage/sys-devel/llvm-roc-5.0.2-r1/work/llvm-project-rocm-5.0.2/llvm_build/projects/openmp/libomptarget/deviceRTLs/libm/../../../runtime/src
------------------- DIR: /var/tmp/portage/sys-devel/llvm-roc-5.0.2-r1/work/llvm-project-rocm-5.0.2/llvm_build/projects/openmp/libomptarget/deviceRTLs/libm/../../../runtime/src
   -- Building hostrpc with LLVM 14.0.0roc found at /usr/lib/llvm/roc
-- LIBOMPTARGET: Building DeviceRTL. Using clang: CLANG_TOOL-NOTFOUND

CLANG_TOOL-NOTFOUND does it depend strictly on clang-14?

@littlewu2508
Copy link
Contributor Author

CLANG_TOOL-NOTFOUND does it depend strictly on clang-14?

Hmm I met other errors if clang-14 or llvm-roc is absent. Seems that a better solution to build libomp after installation of llvm-roc, just like sys-libs/libomp does.

@heroxbd
Copy link
Contributor

heroxbd commented Jun 1, 2022

Hmm I met other errors if clang-14 or llvm-roc is absent. Seems that a better solution to build libomp after installation of llvm-roc, just like sys-libs/libomp does.

I think that's the way to go. Yes.

@heroxbd heroxbd self-requested a review June 10, 2022 15:40
@heroxbd
Copy link
Contributor

heroxbd commented Jun 13, 2022

Any updates?

@littlewu2508
Copy link
Contributor Author

Any updates?

Currently not.

I decided to leave this issue together with https://bugs.gentoo.org/851702

I guess we should make some changes to the current status. sys-devel/llvm-roc is a simple installation which does not fit into Gentoo's llvm slotting logic, and that causes problems: when programs not only depends on hip but also (indirectly) links to (system) llvm, things broke.

Also, libomp can be also handled if we follow the Gentoo's llvm installation paradigm. Finding a way to merge llvm-roc into Gentoo's llvm system, is the ultimate solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants