Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-admin/tpm: Added #25334

Closed
wants to merge 1 commit into from
Closed

app-admin/tpm: Added #25334

wants to merge 1 commit into from

Conversation

orbea
Copy link
Contributor

@orbea orbea commented May 5, 2022

This program is entirely portable shell and should be truly architecture independent. I'm not sure what the best practice for KEYWORDS is here?

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @orbea
Areas affected: ebuilds
Packages affected: app-admin/tpm

app-admin/tpm: @gentoo/proxy-maint (new package)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels May 5, 2022
@orbea orbea force-pushed the tpm branch 2 times, most recently from a831db2 to c65e32a Compare May 5, 2022 16:53
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-05 17:05 UTC
Newest commit scanned: c65e32a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/bc28a965b9/output.html

thesamesam
thesamesam reviewed May 7, 2022
View reviewed changes
Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny comments. I think you should be fine to throw into metadata. We don't tend to bother keywording pre-emptively for other stuff but if you want to, I'm not going to argue with it at all. Up to you.

If you want, you can copy them from something which has a bunch of keywords (get the full list from acct-user.eclass or whatever)?

app-admin/tpm/tpm-1.3.3.ebuild Outdated Show resolved Hide resolved
app-admin/tpm/tpm-1.3.3.ebuild Outdated Show resolved Hide resolved
app-admin/tpm/metadata.xml Outdated Show resolved Hide resolved
@orbea
app-admin/tpm: Added
06d5d38 
Signed-off-by: orbea <orbea@riseup.net>
@gentoo-bot gentoo-bot closed this in 41d3af3 May 7, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-07 06:00 UTC
Newest commit scanned: 06d5d38
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8df2eea8f7/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam thesamesam left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@orbea @gentoo-bot @gentoo-repo-qa-bot @thesamesam