Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-libs/libxcrypt: fix cross + system dependencies #25348

Closed

Conversation

10ne1
Copy link
Contributor

@10ne1 10ne1 commented May 6, 2022

Starting with the v4.4.28 ebuild, libxcrypt supports cross-* builds
so we need to ensure the dependencies are properly specified, for
eg: aarch64-cros-linux-gnu/libxcrypt needs to depend on the
aarch64-cros-linux-gnu/glibc instead of plain sys-libs/glibc.

Bug: https://bugs.gentoo.org/842906
Signed-off-by: Adrian Ratiu adrian.ratiu@collabora.com

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @10ne1
Areas affected: ebuilds
Packages affected: sys-libs/libxcrypt

sys-libs/libxcrypt: @gentoo/toolchain

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels May 6, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-06 09:20 UTC
Newest commit scanned: ec37206
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d229779c49/output.html

Starting with the v4.4.28 ebuild, libxcrypt supports cross-* builds
so we need to ensure the dependencies are properly specified, for
eg: aarch64-cros-linux-gnu/libxcrypt needs to depend on the
aarch64-cros-linux-gnu/glibc instead of plain sys-libs/glibc.

Bug: https://bugs.gentoo.org/842906
Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
@10ne1 10ne1 force-pushed the dev/aratiu/libxcrypt-fix-cross-build-deps branch from ec37206 to 9868330 Compare May 6, 2022 10:28
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-06 10:41 UTC
Newest commit scanned: 9868330
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7ad566518d/output.html

@thesamesam thesamesam closed this May 7, 2022
@thesamesam
Copy link
Member

thesamesam commented May 7, 2022

Nice, thanks!

(wrong button..)

@thesamesam thesamesam reopened this May 7, 2022
@gentoo-bot gentoo-bot closed this in ac6191e May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants