Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-editors/{vscode,vscodium}: version bump to 1.67.0 #25374

Closed
wants to merge 4 commits into from
Closed

app-editors/{vscode,vscodium}: version bump to 1.67.0 #25374

wants to merge 4 commits into from

Conversation

AdelKS
Copy link
Contributor

@AdelKS AdelKS commented May 7, 2022 •
edited

Hello,

A little version bump for vscode and vscodium. The vscodium package is missing the arm arch because of dependency issues, more information here. So we will drop it for now.

Adel

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @AdelKS
Areas affected: ebuilds
Packages affected: app-editors/vscode

app-editors/vscode: @AdelKS, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels May 7, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-07 20:00 UTC
Newest commit scanned: e25313b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a343819711/output.html

@AdelKS
Copy link
Contributor Author

AdelKS commented May 7, 2022

@arthurzam Ready to go! (check my first comment, I dropped arm from vscodium for now)

@arthurzam
Copy link
Member

arthurzam commented May 7, 2022 •
edited

@AdelKS I think the fix for wlroots was merged for 1.67.0 - could you test id I'm correct
Either way, tomorrow I can test on my sway machine.

Please include the arm drop info and link in commit message.

@arthurzam arthurzam self-requested a review May 7, 2022 20:09
@arthurzam arthurzam self-assigned this May 7, 2022
@AdelKS
Copy link
Contributor Author

AdelKS commented May 7, 2022

I think the fix for wlroots was merged for 1.67.0 - could you test id I'm correct
Either way, tomorrow I can test on my sway machine.

Yeah please check (I do not have sway installed), I couldn't find information about it, as the relevant issue did not get proper tags to understand if it got released or not.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-07 20:31 UTC
Newest commit scanned: 54dd995
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7445c2da25/output.html

arthurzam
arthurzam suggested changes May 8, 2022
View reviewed changes
Copy link
Member

@arthurzam arthurzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it works on gui-wm/sway-1.7 and gui-libs/wlroots-0.15.1 - please remove the has_version warning 😄

AdelKS added 4 commits May 8, 2022 20:33
@AdelKS
app-editors/vscode: version bump to 1.67.0
d66ea6b 
The wlroots issue related to Electron is fixed in this release
Closes: https://bugs.gentoo.org/834082

Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com>
@AdelKS
app-editors/vscode: remove old version 1.64.2
6427d6f 
Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com>
@AdelKS
app-editors/vscodium: version bump to 1.67.0
b945d9d 
The wlroots issue related to Electron is fixed in this release
Closes: https://bugs.gentoo.org/834082

Drop arm version as upstream has issues bundling it for now
See VSCodium/vscodium#1072

Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com>
@AdelKS
app-editors/vscodium: drop old version (1.64.2)
68709ed 
Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com>
arthurzam
arthurzam approved these changes May 8, 2022
View reviewed changes
Copy link
Member

@arthurzam arthurzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - good job!

@gentoo-bot gentoo-bot closed this in 98246ee May 8, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-08 18:46 UTC
Newest commit scanned: 68709ed
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fec593ec4d/output.html

@bobby285271 bobby285271 mentioned this pull request May 11, 2022
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurzam arthurzam arthurzam approved these changes

@ArnaudLier ArnaudLier ArnaudLier approved these changes

Assignees

@arthurzam arthurzam

Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
5 participants
@AdelKS @gentoo-bot @gentoo-repo-qa-bot @arthurzam @ArnaudLier