amdgpu-pro vulkan and AMF bumps

[AdelKS]

Hello!

I brought some changes that I'd like special attention to, since ffmpeg needs the headers from amf-headers to be built with the amf use flag :

• I expect that when amf-headers gets updated, ffmpeg needs to be rebuilt : so I slotted amf-headers and made ffmpeg get rebuilt accordingly. But I am not sure about that, it is usual to do that for apps that depend on headers right ?
• Also, I had wrongly put amf-headers in BDEPEND in ffmpeg yet it had to be in DEPEND

[gentoo-bot]

Pull Request assignment

Submitter: @AdelKS
Areas affected: ebuilds
Packages affected: media-libs/amdgpu-pro-vulkan, media-libs/amf-headers, media-video/amdgpu-pro-amf, media-video/ffmpeg

media-libs/amdgpu-pro-vulkan: @AdelKS, @gentoo/proxy-maint
media-libs/amf-headers: @AdelKS, @gentoo/proxy-maint
media-video/amdgpu-pro-amf: @AdelKS, @gentoo/proxy-maint
media-video/ffmpeg: @gentoo/video

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2022-05-07 21:20 UTC
Newest commit scanned: dbcd924
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3eb9ed5c03/output.html

[juippis]

So are you absolutely sure about the header requirement here?

[AdelKS]

So are you absolutely sure about the header requirement here?

I am not sure I understand your question. For ffmpeg to be built with amf useflag, the headers are absolutely needed. What I am unsure about is the need to rebuild when updating the headers and I only used common sense on that.

The thing is that the library is always backward-compatible with all previous AMD drivers, but only the newer ones can leverage the new features. And ffmpeg dlopens the shared library installed by amdgpu-pro-amf.

I would like your input on this, or anyone's input with experience on such matters.

[AdelKS]

Hello @juippis

I cancelled my slotting changes for now, this PR is a simple version bump + a fix of deps in ffmpeg.

I will wait for the answer on GPUOpen-LibrariesAndSDKs/AMF#313 to do further changes. By the look of their repository, that contains a copy of ffmpeg that did not get updated with the recent amf-headers 1.4.24, I think it's either

• ffmpeg needs further patches from AMD to pickup the new features
• the features are controlled by amdgpu-pro-amf and not ffmpeg who's a simple user

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2022-05-29 15:21 UTC
Newest commit scanned: 4ee9314
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a7221f12c8/output.html

[juippis]

Now this on the other hand doesn't require a revbump to ffmpeg :) rest of this PR works so I guess I'll move and rebase this revbump out. Thanks!