Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-emulation/vagrant add 2.2.19; drop 2.2.7-r1, 2.2.9-r1 #25475

Closed
wants to merge 2 commits into from

Conversation

Kangie
Copy link
Contributor

@Kangie Kangie commented May 13, 2022

No description provided.

Signed-off-by: Matt Jolly <Matt.Jolly@footclan.ninja>
Signed-off-by: Matt Jolly <Matt.Jolly@footclan.ninja>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @Kangie
Areas affected: ebuilds
Packages affected: app-emulation/vagrant

app-emulation/vagrant: @GuillaumeSeren, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels May 13, 2022
@Kangie
Copy link
Contributor Author

Kangie commented May 13, 2022

Not sure why the virtualbox use flag was dropped, but it's not in 2.2.18-r1 and the releases that still had it are > 2 years old (and I dropped those).

Assumption is that the use flag is no longer required. @GuillaumeSeren thoughts?

Edit: Looking more closely at the latest ebuilds it appears that the use flag isn't required to activate that functionality.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-13 23:56 UTC
Newest commit scanned: 523901c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e41c4bfb43/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was moved correctly to optfeature, since it had no function in the ebuild. We have a policy against using use flags to control optional runtime features.
https://projects.gentoo.org/qa/policy-guide/dependencies.html#pg0001

@Kangie Kangie deleted the bump-vagrant branch October 25, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants