Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-i18n/scim-bridge: Build fixes #25505

Closed
wants to merge 2 commits into from
Closed

Conversation

orbea
Copy link
Contributor

@orbea orbea commented May 15, 2022

This fixes two unrelated build issues with app-i18n/scim-bridge.

  1. Uses a Fedora patch to fix a -fpermissive build issue.
  2. Uses pkg-config to find -lx11 and fix -no-undefined build issues that GNU libtool silently ignores.

Bug: https://bugs.gentoo.org/645168
Bug: https://bugs.gentoo.org/779121
Fedora Commit: https://src.fedoraproject.org/rpms/scim-bridge/c/0532ab48617e02f5bfb1edaba17b22e88d9beaf4
Upstream PR: https://sourceforge.net/p/scim/patches/15/

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @orbea
Areas affected: ebuilds
Packages affected: app-i18n/scim-bridge

app-i18n/scim-bridge: @gentoo/cjk

Linked bugs

Bugs linked: 645168, 779121


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 15, 2022
@orbea
Copy link
Contributor Author

orbea commented May 15, 2022

Note that packages.gentoo.org claims that 0.14.17 is available, upstream has no such download and Mageia is the only distro that ships 0.14.17 with a download url that doesn't work. I'm not sure what is up with this.

See:

https://packages.gentoo.org/packages/app-i18n/scim-bridge
https://sourceforge.net/projects/scim/files/scim-bridge/
https://repology.org/project/scim-bridge/versions
https://madb.mageia.org/package/show/source/1/application/0/release/cauldron/name/scim-bridge
http://downloads.sourceforge.net/scim/scim-bridge-0.4.17.tar.gz (Mageia download URL - Dead link)

@orbea
Copy link
Contributor Author

orbea commented May 15, 2022

Also note that the qt3 and qt4 builds in scim-bridge probably have the same issue with missing -lx11, but I don't think anyone cares about those anymore.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-15 18:26 UTC
Newest commit scanned: bc38049
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c2c4b1932f/output.html

With slibtool the gtk+2 build fails with undefined references for -lx11
which is missing entirely.

GNU libtool silently hides the bug by ignoring -no-undefined while
slibtool does not do this.

Bug: https://bugs.gentoo.org/779121
Upstream-PR: https://sourceforge.net/p/scim/patches/15/
Signed-off-by: orbea <orbea@riseup.net>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-15 18:46 UTC
Newest commit scanned: d4bcd35
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d289df3661/output.html

@orbea orbea deleted the scim-bridge branch May 15, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
3 participants