Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc-package.eclass: Avoid reserved function name #25521

Merged
merged 2 commits into from May 20, 2022
Merged

ghc-package.eclass: Avoid reserved function name #25521

merged 2 commits into from May 20, 2022

Conversation

ulm
Copy link
Member

@ulm ulm commented May 16, 2022

Rename function ghc-extractportageversion to ghc-extract-pm-version.

Closes: https://bugs.gentoo.org/843713

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @ulm
Areas affected: eclasses
Packages affected: (none)

@gentoo/github

Linked bugs

Bugs linked: 843713

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 16, 2022
@ulm ulm requested a review from markwright May 16, 2022 06:34
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-16 09:16 UTC
Newest commit scanned: ef19e97
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/91337b5052/output.html

solpeth added a commit to gentoo-haskell/gentoo-haskell that referenced this pull request May 17, 2022
@solpeth
ghc-package.eclass, haskell-cabal.eclass: rename function
f3f3d67 
Rename non-conforming function name. Patch pulled
from gentoo/gentoo#25521, written
by Ulrich Müller <ulm@gentoo.org>.

Bug: https://bugs.gentoo.org/843713

Signed-off-by: Jack Todaro <solpeth@posteo.org>
@solpeth
Copy link
Contributor

solpeth commented May 17, 2022

@ulm I've pulled this into the ::haskell overlay at gentoo-haskell/gentoo-haskell@f3f3d67.

ulm added 2 commits May 20, 2022 19:15
@ulm
ghc-package.eclass: Avoid reserved function name
5c8a87e 
Rename function ghc-extractportageversion to ghc-extract-pm-version.

Closes: https://bugs.gentoo.org/843713
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
@ulm
haskell-cabal.eclass: Update function call
a4580b5 
ghc-extractportageversion was renamed to ghc-extract-pm-version.

Bug: https://bugs.gentoo.org/843713
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
@gentoo-bot gentoo-bot merged commit a4580b5 into gentoo:master May 20, 2022
@ulm ulm deleted the ghc-package branch May 20, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwright markwright Awaiting requested review from markwright

Assignees
No one assigned
Labels
bug linked Bug/Closes found in footer, and cross-linked with the PR. need assignment It was impossible to assign the PR correctly. Please assign it manually.
Projects
None yet
Milestone
No milestone
4 participants
@ulm @gentoo-bot @gentoo-repo-qa-bot @solpeth