Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-db/mariadb: bump to 10.3.34/10.3.35 #25554

Closed
wants to merge 2 commits into from

Conversation

hydrapolic
Copy link
Contributor

@hydrapolic hydrapolic commented May 18, 2022

Tests pass on amd64:

ulimit -n 16500
MTR_PARALLEL=64 USE='extraengine perl server xml' FEATURES='test userpriv' emerge -v1 =dev-db/mariadb-10.3.34
ulimit -n 16500
MTR_PARALLEL=64 USE='extraengine perl server xml' FEATURES='test userpriv' emerge -v1 =dev-db/mariadb-10.3.35
--- mariadb-10.3.32.ebuild      2022-05-31 18:32:10.234394185 +0000
+++ mariadb-10.3.34.ebuild      2022-05-31 18:38:13.457031046 +0000
@@ -10,7 +10,7 @@
        multiprocessing java-pkg-opt-2 cmake
 
 # Patch version
-PATCH_SET="https://dev.gentoo.org/~whissi/dist/${PN}/${PN}-10.3.32-patches-01.tar.xz"
+PATCH_SET="https://github.com/hydrapolic/gentoo-dist/raw/master/${PN}/${PN}-10.3.34-patches-01.tar.xz"
 
 SRC_URI="mirror://mariadb/${PN}-${PV}/source/${P}.tar.gz
        ${PATCH_SET}"
@@ -30,9 +30,9 @@
 REQUIRED_USE="jdbc? ( extraengine server !static )
        server? ( tokudb? ( jemalloc !tcmalloc ) )
        ?? ( tcmalloc jemalloc )
-       static? ( yassl !pam )"
+       static? ( yassl !extraengine !pam )"
 
-KEYWORDS="~alpha amd64 arm arm64 ~hppa ~ia64 ~mips ppc ppc64 ~s390 ~sparc x86 ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x64-solaris ~x86-solaris"
+KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~mips ~ppc ~ppc64 ~s390 ~sparc ~x86 ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x64-solaris ~x86-solaris"
 
 # Shorten the path because the socket path length must be shorter than 107 chars
 # and we will run a mysql server during test phase
@@ -454,7 +454,7 @@
 }
 
 # Official test instructions:
-# USE='extraengine perl server' \
+# USE='extraengine perl server xml' \
 # FEATURES='test userpriv' \
 # ebuild mariadb-X.X.XX.ebuild \
 # digest clean package
@@ -682,6 +682,9 @@
                        rm "${ED}/usr/bin/${scriptremove}" || die
                fi
        done
+
+       # Remove dangling symlink
+       rm "${ED}/usr/$(get_libdir)/libmariadb.a" || die
 }
 
 pkg_preinst() {

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels May 18, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-18 21:46 UTC
Newest commit scanned: 4e02766
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5d52d06281/output.html

@thesamesam thesamesam requested a review from robbat2 May 18, 2022 22:03
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With

USE="-backup bindist client-libs -cracklib extraengine galera -innodb-lz4 -innodb-lzo innodb-snappy -jdbc -jdbc jemalloc kerberos -latin1 -mroonga numa odbc oqgraph -pam perl profiling -rocksdb server -sphinx -sst-mariabackup -sst-rsync static -systemtap -tcmalloc tokudb xml yassl" emerge -1av =dev-db/mariadb-10.3.34

I get:

CMake Error at cmake/plugin.cmake:298 (MESSAGE):
  Plugin SPIDER cannot be built
Call Stack (most recent call first):
  CMakeLists.txt:424 (CONFIGURE_PLUGINS)

Let me know if you can't replicate, I'll upload the logs (they seem pretty huge)

The servers were restarted 1016 times
Spent 4756.446 of 1777 seconds executing testcases

Completed: All 3586 tests were successful.

677 tests were skipped, 256 by the test itself.

 * Tests successfully completed
>>> Completed testing dev-db/mariadb-10.3.34

@hydrapolic
Copy link
Contributor Author

Thanks for testing, seems like this combination is problematic (testing with 10.3.35):

USE="extraengine static yassl -pam" emerge -1av =dev-db/mariadb-10.3.35

@hydrapolic hydrapolic changed the title dev-db/mariadb: bump to 10.3.34 dev-db/mariadb: bump to 10.3.34/10.3.35 May 31, 2022
@hydrapolic hydrapolic changed the title dev-db/mariadb: bump to 10.3.34/10.3.35 dev-db/mariadb: bump to 10.3.34/10.3.35 [please reassign] May 31, 2022
@hydrapolic
Copy link
Contributor Author

Added blocker on extraengine for USE=static.

@gentoo-bot gentoo-bot changed the title dev-db/mariadb: bump to 10.3.34/10.3.35 [please reassign] dev-db/mariadb: bump to 10.3.34/10.3.35 May 31, 2022
@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. security PR that needs to be merged promptly as it addresses security issues no signoff One or more commits do not indicate GCO sign-off. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels May 31, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-31 19:01 UTC
Newest commit scanned: a071d64
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/515baaabe8/output.html

Bug: https://bugs.gentoo.org/832490
Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
Bug: https://bugs.gentoo.org/832490
Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
@hydrapolic hydrapolic changed the title dev-db/mariadb: bump to 10.3.34/10.3.35 dev-db/mariadb: bump to 10.3.34/10.3.35 [please reassign] May 31, 2022
@gentoo-bot gentoo-bot changed the title dev-db/mariadb: bump to 10.3.34/10.3.35 [please reassign] dev-db/mariadb: bump to 10.3.34/10.3.35 May 31, 2022
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @hydrapolic
Areas affected: ebuilds
Packages affected: dev-db/mariadb

dev-db/mariadb: @gentoo/mysql

Linked bugs

Bugs linked: 832490


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off. labels May 31, 2022
@gentoo-bot gentoo-bot added the bug linked Bug/Closes found in footer, and cross-linked with the PR. label May 31, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-31 20:56 UTC
Newest commit scanned: 88ad7d1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0cda81cbed/output.html

@hydrapolic
Copy link
Contributor Author

Thank you @thesamesam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. security PR that needs to be merged promptly as it addresses security issues
Projects
None yet
4 participants